Remove reference to BlockSource

Author: Conor Okus

examples/bitcoind-rpc-client/README.md

@@ -1,8 +1,8 @@
-# Creates a basic bitcoind client
+# Wallet actions with an RPC client
 
 This is example shows how you could create a client that directly communicates with bitcoind from LDK. The API is flexible and allows for different ways to implement the interface.
 
-It implements some basic RPC methods that allow you to create a core wallet and print it's balance to stdout.
+It implements some basic RPC methods that allow you to create a wallet and print it's balance to stdout.
 
 To run with this example you need to have a bitcoin core node running in regtest mode. Get the bitcoin core binary either from the [bitcoin core repo](https://bitcoincore.org/bin/bitcoin-core-0.22.0/) or [build from source](https://github.com/bitcoin/bitcoin/blob/v0.21.1/doc/build-unix.md).
 
@@ -29,9 +29,5 @@ Cargo run
 
 The purpose of `RpcClient` is to create a new RPC client connected to the given endpoint with the provided credentials. The credentials should be a base64 encoding of a user name and password joined by a colon, as is required for HTTP basic access authentication.
 
-It implements [BlockSource](https://github.com/rust-bitcoin/rust-lightning/blob/61341df39e90de9d650851a624c0644f5c9dd055/lightning-block-sync/src/lib.rs#L55) against a Bitcoin Core RPC. It is an asynchronous interface for retrieving block headers and data.
-
-Check out our [LDK sample node](https://github.com/lightningdevkit/ldk-sample) for an integrated example.
-
 
 

examples/bitcoind-rpc-client/src/bitcoind_client.rs

@@ -1,7 +1,6 @@
 use std::{sync::{Arc}, io};
 
-use bitcoin::{BlockHash, Block};
-use lightning_block_sync::{rpc::RpcClient, http::{HttpEndpoint}, BlockSource, AsyncBlockSourceResult, BlockHeaderData};
+use lightning_block_sync::{rpc::RpcClient, http::{HttpEndpoint}};
 use serde_json::json;
 use tokio::sync::Mutex;
 
@@ -16,33 +15,6 @@ pub struct BitcoindClient {
     rpc_password: String,
 }
 
-impl BlockSource for &BitcoindClient {
-	fn get_header<'a>(
-		&'a mut self, header_hash: &'a BlockHash, height_hint: Option<u32>,
-	) -> AsyncBlockSourceResult<'a, BlockHeaderData> {
-		Box::pin(async move {
-			let mut rpc = self.bitcoind_rpc_client.lock().await;
-			rpc.get_header(header_hash, height_hint).await
-		})
-	}
-
-	fn get_block<'a>(
-		&'a mut self, header_hash: &'a BlockHash,
-	) -> AsyncBlockSourceResult<'a, Block> {
-		Box::pin(async move {
-			let mut rpc = self.bitcoind_rpc_client.lock().await;
-			rpc.get_block(header_hash).await
-		})
-	}
-
-	fn get_best_block<'a>(&'a mut self) -> AsyncBlockSourceResult<(BlockHash, Option<u32>)> {
-		Box::pin(async move {
-			let mut rpc = self.bitcoind_rpc_client.lock().await;
-			rpc.get_best_block().await
-		})
-	}
-}
-
 impl BitcoindClient {
     pub async fn new(host: String, port: u16, rpc_user: String, rpc_password: String) -> io::Result<Self> {
         let http_endpoint = HttpEndpoint::for_host(host.clone()).with_port(port);