f Return early if nothing to do, scope outputs lock

Author: tnull

src/sweep.rs

@@ -259,20 +259,26 @@ where
 			.filter(|desc| !matches!(desc, SpendableOutputDescriptor::StaticOutput { .. }))
 			.collect::<Vec<_>>();
 
-		let mut locked_outputs = self.outputs.lock().unwrap();
-		for descriptor in non_static_outputs {
-			let id = self.keys_manager.get_secure_random_bytes();
-			let output_info = SpendableOutputInfo {
-				id,
-				descriptor,
-				channel_id,
-				status: SpendableOutputStatus::Pending,
-			};
+		if non_static_outputs.is_empty() {
+			return;
+		}
 
-			locked_outputs.push(output_info.clone());
-			self.persist_status(&output_info).unwrap_or_else(|e| {
-				log_error!(self.logger, "Error persisting spendable output status: {:?}", e)
-			});
+		{
+			let mut locked_outputs = self.outputs.lock().unwrap();
+			for descriptor in non_static_outputs {
+				let id = self.keys_manager.get_secure_random_bytes();
+				let output_info = SpendableOutputInfo {
+					id,
+					descriptor,
+					channel_id,
+					status: SpendableOutputStatus::Pending,
+				};
+
+				locked_outputs.push(output_info.clone());
+				self.persist_status(&output_info).unwrap_or_else(|e| {
+					log_error!(self.logger, "Error persisting spendable output status: {:?}", e)
+				});
+			}
 		}
 
 		self.rebroadcast_if_necessary();