Code clean up and worked on tests

Author: joachimmetz

ChangeLog

@@ -1,4 +1,6 @@
 TODO
+* add threads RW lock to item
+* remove libpff_item_clone
 * pypff fix get_root_item
 
 IOError: pypff_file_get_item_type_object: unable to retrieve item type.
@@ -10,7 +12,6 @@ libpff_item_get_type: unable to determine item type.
 
 * refactor libpff_message_get_entry_value_utf8_string to match naming schema
 * add specific entry value flag for string types?
-* add fallback inflate implementation
 * add libpff_item_values_get_record_entry_by_type specific for string types?
 * API add
   - libpff_multi_value_get_value_16bit

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ( 2.59 )
 
 AC_INIT(
  [libpff],
- [20200719],
+ [20200720],
  [joachim.metz@gmail.com])
 
 AC_CONFIG_SRCDIR(

include/libpff.h.in

@@ -627,7 +627,7 @@ int libpff_item_get_value_type(
 
 /* Retrieves the value of a specific entry
  *
- * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE is set
+ * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE flag is set
  * the value type is ignored and set. The default behavior is a strict
  * matching of the value type. In this case the value type must be filled
  * with the corresponding value type
@@ -1630,7 +1630,7 @@ int libpff_record_set_get_entry_by_index(
 
 /* Retrieves the record entry matching the entry and value type pair from the record set
  *
- * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE is set
+ * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE flag is set
  * the value type is ignored and set. The default behavior is a strict
  * matching of the value type. In this case the value type must be filled
  * with the corresponding value type
@@ -1653,7 +1653,7 @@ int libpff_record_set_get_entry_by_type(
 
 /* Retrieves the record entry matching the UTF-8 encoded name from the record set.
  *
- * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE is set
+ * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE flag is set
  * the value type is ignored and set. The default behavior is a strict
  * matching of the value type. In this case the value type must be filled
  * with the corresponding value type
@@ -1672,7 +1672,7 @@ int libpff_record_set_get_entry_by_utf8_name(
 
 /* Retrieves the record entry matching the UTF-16 encoded name from the record set.
  *
- * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE is set
+ * When the LIBPFF_ENTRY_VALUE_FLAG_MATCH_ANY_VALUE_TYPE flag is set
  * the value type is ignored and set. The default behavior is a strict
  * matching of the value type. In this case the value type must be filled
  * with the corresponding value type

libpff/libpff_attachment.c

@@ -731,7 +731,6 @@ int libpff_attachment_get_item(
 {
 	libcdata_tree_node_t *embedded_item_tree_node           = NULL;
 	libpff_internal_item_t *internal_item                   = NULL;
-	libpff_item_descriptor_t *embedded_item_descriptor      = NULL;
 	libpff_local_descriptor_value_t *local_descriptor_value = NULL;
 	libpff_record_entry_t *record_entry                     = NULL;
 	libpff_record_set_t *record_set                         = NULL;
@@ -756,17 +755,6 @@ int libpff_attachment_get_item(
 	}
 	internal_item = (libpff_internal_item_t *) attachment;
 
-	if( internal_item->internal_file == NULL )
-	{
-		libcerror_error_set(
-		 error,
-		 LIBCERROR_ERROR_DOMAIN_RUNTIME,
-		 LIBCERROR_RUNTIME_ERROR_VALUE_MISSING,
-		 "%s: invalid attachment - missing internal file.",
-		 function );
-
-		return( -1 );
-	}
 	if( internal_item->item_values == NULL )
 	{
 		libcerror_error_set(
@@ -859,7 +847,7 @@ int libpff_attachment_get_item(
 /* TODO add support for recovered embedded items */
 
 		result = libpff_item_tree_get_node_by_identifier(
-			  internal_item->internal_file->item_tree,
+			  internal_item->item_tree,
 			  embedded_object_item_identifier,
 			  &embedded_item_tree_node,
 			  error );
@@ -997,29 +985,15 @@ int libpff_attachment_get_item(
 				goto on_error;
 			}
 		}
-		if( libcdata_tree_node_get_value(
-		     embedded_item_tree_node,
-		     (intptr_t **) &embedded_item_descriptor,
-		     error ) != 1 )
-		{
-			libcerror_error_set(
-			 error,
-			 LIBCERROR_ERROR_DOMAIN_RUNTIME,
-			 LIBCERROR_RUNTIME_ERROR_GET_FAILED,
-			 "%s: unable to retrieve embedded item descriptor.",
-			 function );
-
-			goto on_error;
-		}
 		if( libpff_item_initialize(
 		     attached_item,
 		     internal_item->io_handle,
 		     internal_item->file_io_handle,
-		     internal_item->internal_file,
 		     internal_item->name_to_id_map_list,
+		     internal_item->descriptors_index,
 		     internal_item->offsets_index,
+		     internal_item->item_tree,
 		     embedded_item_tree_node,
-		     embedded_item_descriptor,
 		     LIBPFF_ITEM_FLAGS_DEFAULT,
 		     error ) != 1 )
 		{