Share DNS and Connect between curl requests #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces overhead when doing multiple curl requests per php-request. other places which manually invoke `curl_init` can benefit in a similar way by adding such code. `curl_multi_*` will automatically share caches between requests, without the need for additional code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces overhead when doing multiple curl requests per php-request.
starting with PHP 8.5 this even allows caching across php-requests.
other places which manually invoke
curl_initcan benefit in a similar way by adding such code.curl_multi_*will automatically share caches between requests, without the need for additional code.we could also add
CURL_LOCK_DATA_SSL_SESSION, but I was not sure whether this has security implications. therefore I left it out for now.analog lesstif/php-JiraCloud-RESTAPI#117