From 31de9acc8e5be6a619d3c1d1ed477f6595dd79bb Mon Sep 17 00:00:00 2001 From: Ben Du Date: Sat, 20 Jun 2026 16:02:56 -0700 Subject: [PATCH] refactor: remove redundant runtime type checks --- github_rest_api/github.py | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/github_rest_api/github.py b/github_rest_api/github.py index 842e5b2..ab99f42 100644 --- a/github_rest_api/github.py +++ b/github_rest_api/github.py @@ -200,8 +200,6 @@ def create_release(self, json: dict[str, Any]): For more details, please refer to https://docs.github.com/en/rest/releases/releases#create-a-release. """ - if not isinstance(json, dict): - raise ValueError("A dict value is required for `json`.") return self._post( url=self._url_releases, json=json, @@ -238,8 +236,6 @@ def create_pull_request(self, json: dict[str, str]) -> dict[str, Any] | None: about the pull request to be created. It's passed to the json parameter of requests.post. """ - if not isinstance(json, dict): - raise ValueError("A dict value is required for `json`.") if not ("head" in json and "base" in json): raise ValueError("The data dict must contains keys head and base!") # return an existing PR @@ -262,8 +258,6 @@ def merge_pull_request(self, pr_number: int) -> dict[str, Any]: """Merge a pull request in this repository. :param pr_number: The number of the pull quest to be merged. """ - if not isinstance(pr_number, int): - raise ValueError("An integer value is required for `pr_number`.") return self._put( url=f"{self._url_pull}/{pr_number}/merge", ).json() @@ -273,10 +267,6 @@ def update_branch(self, update: str, upstream: str) -> dict[str, Any] | None: :param update: The branch to update. :param upstream: The upstream branch. """ - if not isinstance(update, str): - raise ValueError("A string value is required for `update`.") - if not isinstance(upstream, str): - raise ValueError("A string value is required for `upstream`.") pr = self.create_pull_request( { "base": update, @@ -295,8 +285,6 @@ def get_pull_request_files( :param pr_number: The number of the pull request. """ - if not isinstance(pr_number, int): - raise ValueError("An integer value is required for `pr_number`.") return self._extract_all(url=f"{self._url_pull}/{pr_number}/files", n=n) def get_branches(self, n: int = 0) -> list[dict[str, Any]]: @@ -317,8 +305,6 @@ def delete_ref(self, ref: str) -> requests.Response: """Delete a reference from this repository. :param ref: The reference to delete from this repository. """ - if not isinstance(ref, str): - raise ValueError("A string value is required for `ref`.") return self._delete( url=f"{self._url_refs}/{ref}", ) @@ -333,8 +319,6 @@ def delete_secret(self, name: str) -> requests.Response: """Delete a secret from this repository. :param name: The name of the secret to delete. """ - if not isinstance(name, str): - raise ValueError("A string value is required for `name`.") return self._delete( url=f"{self._url_secrets}/{name}", ) @@ -353,10 +337,6 @@ def create_or_update_secret( to encrypt the secret with. Fetch it once and reuse it to avoid a redundant request when creating or updating multiple secrets. """ - if not isinstance(name, str): - raise ValueError("A string value is required for `name`.") - if not isinstance(value, str): - raise ValueError("A string value is required for `value`.") return self._put( url=f"{self._url_secrets}/{name}", json={ @@ -394,10 +374,6 @@ def create_issue_comment(self, issue_number: int, body: str) -> dict[str, Any]: :param issue_number: The number of the issue. :param body: Body text of the new comment. """ - if not isinstance(issue_number, int): - raise ValueError("An integer value is required for `issue_number`.") - if not isinstance(body, str): - raise ValueError("A string message is required for `body`.") return self._post( url=f"{self._url_issues}/{issue_number}/comments", json={"body": body}, @@ -522,8 +498,6 @@ def delete_secret(self, name: str) -> requests.Response: """Delete an organization secret. :param name: The name of the secret to delete. """ - if not isinstance(name, str): - raise ValueError("A string value is required for `name`.") return self._delete( url=f"{self._url_secrets}/{name}", ) @@ -551,10 +525,6 @@ def create_or_update_secret( :param selected_repository_ids: Repository IDs that can access the secret when visibility is `selected`. """ - if not isinstance(name, str): - raise ValueError("A string value is required for `name`.") - if not isinstance(value, str): - raise ValueError("A string value is required for `value`.") if selected_repository_ids and visibility != SecretVisibility.SELECTED: raise ValueError( "`selected_repository_ids` can only be provided when `visibility` is 'selected'."