update eslint config

just updating it to the latest one we're using internally

Author: drweissbrot

.eslintrc.json

@@ -30,23 +30,29 @@
 		"@typescript-eslint/ban-ts-ignore": "off",
 		"@typescript-eslint/camelcase": "off",
 		"@typescript-eslint/explicit-function-return-type": "off",
+		"@typescript-eslint/explicit-member-accessibility": "error",
 		"@typescript-eslint/no-empty-function": "off",
 		"@typescript-eslint/no-explicit-any": "off",
+		"@typescript-eslint/no-loop-func": "error",
+		"@typescript-eslint/no-shadow": "error",
 		"@typescript-eslint/no-unused-vars": "off",
+		"@typescript-eslint/no-use-before-define": "error",
 		"arrow-parens": ["error", "always"],
 		"class-methods-use-this": "off",
 		"consistent-return": "off",
 		"curly": "off",
 		"default-case": "off",
 		"dot-notation": "off",
 		"func-names": "off",
+		"function-paren-newline": ["error", "consistent"],
 		"guard-for-in": "off",
 		"import/extensions": "off",
 		"import/newline-after-import": "off",
+		"import/no-extraneous-dependencies": ["error", { "devDependencies": true } ],
 		"import/no-unresolved": "off",
 		"import/prefer-default-export": "off",
-		"indent": ["error", "tab", {"SwitchCase": 1}],
-		"linebreak-style": "off",
+		"indent": ["error", "tab", { "SwitchCase": 1 }],
+		"linebreak-style": ["warn", "unix"],
 		"lines-between-class-members": "off",
 		"max-len": "off",
 		"newline-per-chained-call": "off",
@@ -55,18 +61,22 @@
 		"no-console": "off",
 		"no-continue": "off",
 		"no-dupe-class-members": "off",
+		"no-loop-func": "off",
 		"no-mixed-operators": ["error", { "groups": [ ["&", "|", "^", "~", "<<", ">>", ">>>"], ["&&", "||"] ] }],
 		"no-multi-assign": "off",
+		"no-multiple-empty-lines": "off",
 		"no-new": "off",
 		"no-param-reassign": "off",
 		"no-plusplus": "off",
 		"no-prototype-builtins": "off",
 		"no-restricted-syntax": "off",
 		"no-return-assign": "off",
+		"no-shadow": "off",
 		"no-tabs": "off",
 		"no-underscore-dangle": "off",
 		"no-unreachable": "off",
 		"no-unused-vars": "off",
+		"no-use-before-define": "off",
 		"no-useless-constructor": "off",
 		"object-curly-newline": "off",
 		"padded-blocks": "off",
@@ -77,13 +87,6 @@
 		"quotes": ["error", "single", { "allowTemplateLiterals": true, "avoidEscape": true }],
 		"radix": "off",
 		"semi": 1,
-		"yoda": "off",
-
-		"import/no-extraneous-dependencies": [
-			"error",
-			{
-				"devDependencies": true
-			}
-		]
+		"yoda": "off"
 	}
 }

src/view/options.ts

@@ -60,7 +60,7 @@ export class Options {
 			checkbox.type = 'checkbox';
 			checkbox.checked = !!values[option.key];
 
-			// eslint-disable-next-line no-loop-func
+			// eslint-disable-next-line @typescript-eslint/no-loop-func
 			checkbox.addEventListener('change', async () => {
 				await chrome.storage.sync.set({ [option.key]: checkbox.checked });