-
Notifications
You must be signed in to change notification settings - Fork 57
Switch to Markdown #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switch to Markdown #103
Conversation
…h and add type attribute
Signed-off-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
|
I intended to do more spot-checking but this PR is ready for review now. @pierluc-codes |
|
I made a big final sweep and this is ready for review now. This is a big change, so I'll ping all codeowners hoping to get more eyes on it. The result would benefit from eyeballing more. I also update this PR's description (see at the top) with a list of notable changes. Please, check it out... It'd be good to merge it this week because there are many PR's on the repo that will benefit from rebasing on this. |
This is a new life for #41 (opened in Nov 2022 and abandoned since)
and the project!The PR's version of the site is currently deployed at https://ulysses4ever.github.io/learnyouahaskell.github.io/.
Sadly, because of the many changes, both structural and little but pervasive, the HTML diff isn't very useful. (The Markdown diff is useful.) Hence, the reviewers are advised to open and eyeball the deployed version.
Below I detail main changes that this PR brings.
Main Changes
[1] Makes HTML generated from
/markdown/source_mdstraight to/docswith Pandoc (which becomes a dependency of the project).make) and to clean it up (make clean).[2] Removes all HTML files that can be generated:
docs/*.htmlandmarkdown/generated_html, exceptdocs/index.html. Also removesmarkdown/generated_md(only used as a temporary directory really). This was a HUGE point of confusion for external contributors --- having several versions of the same thing.How's HTML
[3] There are many small changes to the generated HTML vs the current one mostly because the current one is pretty irregular (no closing
</p>tags, some weird combination of p and img tags, etc.). The many changes are meticulously recorded in the commit history inherited from #41.Visually the result looks almost the same (please, double-check!), modulo slight changes in how text flows around images, but that doesn't seem consequential in any way.
How's CSS
[4] There doesn't seem be any changes on
mainsince #41 was forked except for the responsiveness PR #64, which I manually applied.How's textual content
[5] There has been many little text changes since #41 was forked. @pierluc-codes carefully re-implemented them here and I cross-chcecked it.
Minor cleanups and updates
[6] GitHub Workflow will now deploy the website by generating HTML from MD (obviously).
[7] generate.sh was cleaned up a bit, including with
shellcheck.[8] there was duplication of style.css/reset.css (they lived both under
/docsand under/docs/assets/css). There's now only one version (/docs/assets/css).[9] Similar to [8], JS files for the syntax highlighter that lived under
/docswere moved to a more appropriate place under/docs/sh(the directory was there before and held one file already).[10] The new
.gitignoreexcludes the generated files under/docs.old description
TODO:
add textual changes since 2022; they have been collected by @pierluc-codes here: https://gist.github.com/pierluc-codes/9c07c421c087ab114c4456f6eb4f44ae
merge CSS: Make preparations for switching to markdown-generated HTML #41 had some changes, and the upstream had some, especially in Make CSS responsive to improve mobile layout #64; this includes:
The current version is rendered here: https://ulysses4ever.github.io/learnyouahaskell.github.io/chapters.html Note for @pierluc-codes : I had to change the repository I worked from (it used to be ulysses4ever/learnyouahaskell-md) because I cant open pull requests from non-forks.