[Application] Add scenario-scoped alternative recommendations#255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
#245는 이번 PR에서 추천 규칙 엔진의 핵심 흐름은 구현했지만
Closes가 아니라Refs로 남겼습니다. 특히 일방통행 전환 추천은 현재 앱에서 실제 시나리오 조작으로 구현할 수 없고, 사용자가 오해할 가능성이 있어서 이번 PR에서 의도적으로 생성하지 않도록 막았습니다. 통로폭 확장이나 출구 추가 개방처럼 구조 자체를 바꾸는 추천도 현재 scenario workflow에서 안전하게 생성하지 않습니다.Area
Architecture Check
application -> domain -> engine을 유지했습니다.src/domain에 Qt UI 코드를 추가하지 않았습니다.src/engine에domain또는application의존성을 추가하지 않았습니다.src/를 include root로 사용하는 기존 구조를 유지했습니다.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugcmake --build --preset build-debug --target safecrowd_appcmake --build --preset build-no-app-debugctest --preset test-no-app-debugRisks / Follow-up
test-debugpreset은 실행하지 않았습니다. 이번 검증은 앱 타겟 빌드와 현재 CI 경로에 가까운 no-app 테스트 preset에 집중했습니다.