feat(DeriveArbitrary): Support structure-parameterized types#80
Open
mwhicks1 wants to merge 1 commit into
Open
feat(DeriveArbitrary): Support structure-parameterized types#80mwhicks1 wants to merge 1 commit into
mwhicks1 wants to merge 1 commit into
Conversation
Extend the Arbitrary deriving handler to support inductive types parameterized by structures. For structure parameters, recursively expand Type-valued fields into per-field inst-implicit binders (e.g., [Arbitrary T.Meta] or [Arbitrary T.base.IDMeta] for nested structures). Add mkArbitraryInstBinders which replaces mkInstImplicitBinders in mkHeaderWithOnlyImplicitBinders and mkArbitraryFueledInstanceCmds. For each parameter: - If [Arbitrary param] is type-correct, emit it (existing behavior) - Otherwise, if the param's type is a structure, recursively expand its fields, emitting [Arbitrary proj] for each Type-valued leaf - Reject structures with non-Type, non-structure fields (effectively indexed types) with a clear error message Add StructureParameterTest.lean covering: - Simple structure parameters - Mixed normal type + structure parameters - Nested structure parameters (structure containing structure) - Rejection of structures with non-Type fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the Arbitrary deriving handler to support inductive types parameterized by structures. For structure parameters, recursively expand Type-valued fields into per-field inst-implicit binders (e.g., [Arbitrary T.Meta] or [Arbitrary T.base.IDMeta] for nested structures).
Add mkArbitraryInstBinders which replaces mkInstImplicitBinders in mkHeaderWithOnlyImplicitBinders and mkArbitraryFueledInstanceCmds. For each parameter:
Add StructureParameterTest.lean covering: