refactor: use step_fupd_mono more#404
Open
ayhon wants to merge 1 commit into
Open
Conversation
3 tasks
markusdemedeiros
changed the title
Collaborator
|
Ping me when this is ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some lemmas in
BI/Updates.lean, which could use the newly addedstep_fupd_mono.This lemma was not present in Rcoq, I suspect because the generalized rewriting machinery make it not really needed. However, as of now we don't really have generalized rewriting, so having a
step_fupd_monolemma may help when building terms directly.Checklist
PORTING.mdas appropriateauthorssection of any appropriate files