Skip to content

feat: add lifting and ectx lifting#397

Merged
markusdemedeiros merged 11 commits into
leanprover-community:masterfrom
ayhon:fele/feat/add-lifting-and-ectx-lifting
May 23, 2026
Merged

feat: add lifting and ectx lifting#397
markusdemedeiros merged 11 commits into
leanprover-community:masterfrom
ayhon:fele/feat/add-lifting-and-ectx-lifting

Conversation

@ayhon
Copy link
Copy Markdown
Contributor

@ayhon ayhon commented May 18, 2026

Description

Ports lifting.v and ectx-lifting.v.

Fixes #348 and #349.

Builds on top of #393.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

@ayhon ayhon mentioned this pull request May 19, 2026
3 tasks
@ayhon ayhon force-pushed the fele/feat/add-lifting-and-ectx-lifting branch 2 times, most recently from f504cf0 to f146229 Compare May 22, 2026 12:01
@ayhon ayhon marked this pull request as ready for review May 22, 2026 12:48
@markusdemedeiros markusdemedeiros self-requested a review May 22, 2026 14:34
@markusdemedeiros
Copy link
Copy Markdown
Collaborator

This looks pretty good, is it ready to review?

@ayhon
Copy link
Copy Markdown
Contributor Author

ayhon commented May 23, 2026

Yes, I have also gone over the comments I received in my last PR and made changes based on that, so hopefully there won't be much to change (famous last words).

@markusdemedeiros
Copy link
Copy Markdown
Collaborator

Super! On it

@markusdemedeiros
Copy link
Copy Markdown
Collaborator

Beauty :) Thanks for putting in the effort to make your PR quick to review. Aside from a couple style cleanups, the only major change was accepting your proposal to use ∃ v, ⌜(toVal e₂) = some v⌝ ∧ Φ v instead of Option.rec. I suspect the reason they do this in Rocq is to have a form which automatically reduces better in some contexts, but we will try this way since it is cleaner and I suspect pretty easy for us to automate anyways.

@ayhon
Copy link
Copy Markdown
Contributor Author

ayhon commented May 23, 2026

Cool! I think there's a couple more changes I'd like to make in BI/Updates.lean. I recently introduced a step_fupd_mono lemma which was not present in Rocq which might simplify many of our instances of mono <| later_mono <| mono ?_ in the code

EDIT: Well, we can add those in some other PR

@markusdemedeiros markusdemedeiros merged commit 5794ae3 into leanprover-community:master May 23, 2026
5 checks passed
@markusdemedeiros
Copy link
Copy Markdown
Collaborator

Sounds good. If you explore this further please make another PR.

@ayhon
Copy link
Copy Markdown
Contributor Author

ayhon commented May 23, 2026

I opened #404. Warning, it's quite a minor PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port program_logic/lifting.v

2 participants