Revert tv embed removal

[kikkia]

The removal of the TVHTMLEMBEDDED stuff is a bit premature, the client still works fine for loading. If we want to let this sit for a couple days and confirm that's fine. Not sure for how long it will keep working, but they seem to not delete old clients, just block playback, and part of that means leaving metadata in place to tell the user that it is not playable with this client. So I suspect this will still load fine, for the foreseeable future hopefully.

[OxydeBots]

If YouTube decided to kill the client, I would be surprised if it worked again in the future.

[kikkia]

If YouTube decided to kill the client, I would be surprised if it worked again in the future.

Thats not at all what I am saying. What I am saying is:

1. Metadata still works through this endpoint
2. Playback was cutoff, but in this case typically the client still returns metadata, but the playabilityStatus of the return denotes the client is deprecated.
3. Until the metadata / track loading breaks we should keep it around as its still good for track loading.

And building off of 3, at least for the forseeable future it seems possible they keep the metadata returns around, this way the existing TV clients using it display the correct messaging to the old fat dude wondering why his TV stopped playing the youtubes. If they take away the client entirely it just breaks the tv embeds completely. At least for a little while they will keep it around so that users don't think its broken and submit support tickets, the users will see a nice message. That's at least the logic some PM probably goes through over there.

[devoxin]

Could you override supportsFormatLoading to return false, with a log message (printed only once upon calling supportsFormatLoading()) that states TvHtml5Embedded can no longer be used for playback, so format loading has been blocked.

[kikkia]

Some results from testing, they were a bit weird, but I dont have time to dive in right now and figure out whats going on

Using Embed client + TV client (with oauth):
With default settings (all enabled): Track searching and direct link both function fine
Disabling playback on embed: Direct link works fine but search is now broken. TV client gives a sign in error (Oauth only used on googlevideo url iirc)

I spent a little time trying to wrap my head around what was breaking here and the lifecycle of a search vs a direct link and what parts are involved in each. And why disabling playback on embedded, when I assumed it was broken already, messed with it.

Are the playback urls generated during the videoLoading stuff or the playback stuff? Maybe disabling the playback on embedded is also disabling the loading on it?

I don't have time right now to do a proper debug sorry.