Skip to content

Automatic native building & latest natives#187

Open
sqikerz wants to merge 40 commits into
lavalink-devs:mainfrom
sqikerz:build-natives
Open

Automatic native building & latest natives#187
sqikerz wants to merge 40 commits into
lavalink-devs:mainfrom
sqikerz:build-natives

Conversation

@sqikerz
Copy link
Copy Markdown

@sqikerz sqikerz commented Mar 15, 2026

yes (also can't lie, thank you very much big bro @claude)

Run can be viewed at:
https://github.com/sqikerz/lavaplayer/actions/runs/23119077532

@sqikerz
Copy link
Copy Markdown
Author

sqikerz commented Mar 17, 2026

ready for review, I've done all requested changes

Job viewable at: https://github.com/sqikerz/lavaplayer/actions/runs/23174458583

Copy link
Copy Markdown
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mostly looks good i think with some small exceptions

Comment thread natives/.gitignore Outdated
Comment thread jitpack.yml Outdated
Comment thread .github/workflows/build-natives.yml
Copy link
Copy Markdown
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also unsure if caching the natives works as it should
Ideally we would be caching the final binaries of the action output
does it do that rn?

sqikerz added 2 commits March 21, 2026 12:28
- merge gitignore files
- update action workers
- correct publishToMavenLocal to skip natives
- cache action output rather than deps
@sqikerz
Copy link
Copy Markdown
Author

sqikerz commented Mar 21, 2026

I am also unsure if caching the natives works as it should Ideally we would be caching the final binaries of the action output does it do that rn?

It didn't but it does now.

@sqikerz
Copy link
Copy Markdown
Author

sqikerz commented Mar 21, 2026

@sqikerz
Copy link
Copy Markdown
Author

sqikerz commented Mar 21, 2026

Cached run: https://github.com/sqikerz/lavaplayer/actions/runs/23385011933
(also had to rerun to fix dep which was failing)

@sqikerz sqikerz requested a review from topi314 March 21, 2026 18:28
@sqikerz
Copy link
Copy Markdown
Author

sqikerz commented Mar 26, 2026

Need to test running lavaplayer again, give me a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants