Skip to content

Commit 7e6977d

Browse files
committed
Fix tests
1 parent 254009b commit 7e6977d

1 file changed

Lines changed: 6 additions & 31 deletions

File tree

ldclient/testing/impl/datasourcev2/test_streaming_synchronizer.py

Lines changed: 6 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,7 @@ def test_stops_on_unrecoverable_status_code(
418418
events,
419419
): # pylint: disable=redefined-outer-name
420420
error = HTTPStatusError(401)
421-
error.headers = None
422421
fault = Fault(error=error)
423-
fault.headers = None
424422
builder = list_sse_client(
425423
[
426424
# This will generate an error but the stream should continue
@@ -451,14 +449,10 @@ def test_continues_on_recoverable_status_code(
451449
events,
452450
): # pylint: disable=redefined-outer-name
453451
error1 = HTTPStatusError(400)
454-
error1.headers = None
455452
fault1 = Fault(error=error1)
456-
fault1.headers = None
457453

458454
error2 = HTTPStatusError(408)
459-
error2.headers = None
460455
fault2 = Fault(error=error2)
461-
fault2.headers = None
462456

463457
builder = list_sse_client(
464458
[
@@ -497,8 +491,7 @@ def test_continues_on_recoverable_status_code(
497491

498492
def test_envid_from_start_action(events): # pylint: disable=redefined-outer-name
499493
"""Test that environment ID is captured from Start action headers"""
500-
start_action = Start()
501-
start_action.headers = {_LD_ENVID_HEADER: 'test-env-123'}
494+
start_action = Start(headers={_LD_ENVID_HEADER: 'test-env-123'})
502495

503496
builder = list_sse_client(
504497
[
@@ -519,8 +512,7 @@ def test_envid_from_start_action(events): # pylint: disable=redefined-outer-nam
519512

520513
def test_envid_preserved_across_events(events): # pylint: disable=redefined-outer-name
521514
"""Test that environment ID is preserved across multiple events after being set on Start"""
522-
start_action = Start()
523-
start_action.headers = {_LD_ENVID_HEADER: 'test-env-456'}
515+
start_action = Start(headers={_LD_ENVID_HEADER: 'test-env-456'})
524516

525517
builder = list_sse_client(
526518
[
@@ -544,11 +536,7 @@ def test_envid_preserved_across_events(events): # pylint: disable=redefined-out
544536

545537
def test_envid_from_fallback_header():
546538
"""Test that environment ID is captured when fallback header is present"""
547-
start_action = Start()
548-
start_action.headers = {
549-
_LD_ENVID_HEADER: 'test-env-fallback',
550-
_LD_FD_FALLBACK_HEADER: 'true'
551-
}
539+
start_action = Start(headers={_LD_ENVID_HEADER: 'test-env-fallback', _LD_FD_FALLBACK_HEADER: 'true'})
552540

553541
builder = list_sse_client([start_action])
554542

@@ -564,10 +552,8 @@ def test_envid_from_fallback_header():
564552

565553
def test_envid_from_fault_action():
566554
"""Test that environment ID is captured from Fault action headers"""
567-
error = HTTPStatusError(401)
568-
error.headers = {_LD_ENVID_HEADER: 'test-env-fault'}
555+
error = HTTPStatusError(401, headers={_LD_ENVID_HEADER: 'test-env-fault'})
569556
fault_action = Fault(error=error)
570-
fault_action.headers = {_LD_ENVID_HEADER: 'test-env-fault'}
571557

572558
builder = list_sse_client([fault_action])
573559

@@ -584,16 +570,8 @@ def test_envid_from_fault_action():
584570

585571
def test_envid_from_fault_with_fallback():
586572
"""Test that environment ID and fallback are captured from Fault action"""
587-
error = HTTPStatusError(503)
588-
error.headers = {
589-
_LD_ENVID_HEADER: 'test-env-503',
590-
_LD_FD_FALLBACK_HEADER: 'true'
591-
}
573+
error = HTTPStatusError(503, headers={_LD_ENVID_HEADER: 'test-env-503', _LD_FD_FALLBACK_HEADER: 'true'})
592574
fault_action = Fault(error=error)
593-
fault_action.headers = {
594-
_LD_ENVID_HEADER: 'test-env-503',
595-
_LD_FD_FALLBACK_HEADER: 'true'
596-
}
597575

598576
builder = list_sse_client([fault_action])
599577

@@ -609,10 +587,8 @@ def test_envid_from_fault_with_fallback():
609587

610588
def test_envid_from_recoverable_fault(events): # pylint: disable=redefined-outer-name
611589
"""Test that environment ID is captured from recoverable Fault and preserved in subsequent events"""
612-
error = HTTPStatusError(400)
613-
error.headers = {_LD_ENVID_HEADER: 'test-env-400'}
590+
error = HTTPStatusError(400, headers={_LD_ENVID_HEADER: 'test-env-400'})
614591
fault_action = Fault(error=error)
615-
fault_action.headers = {_LD_ENVID_HEADER: 'test-env-400'}
616592

617593
builder = list_sse_client(
618594
[
@@ -639,7 +615,6 @@ def test_envid_from_recoverable_fault(events): # pylint: disable=redefined-oute
639615
def test_envid_missing_when_no_headers():
640616
"""Test that environment ID is None when no headers are present"""
641617
start_action = Start()
642-
start_action.headers = None
643618

644619
server_intent = ServerIntent(
645620
payload=Payload(

0 commit comments

Comments
 (0)