Don't pass --no-ansi to rm, properly check if output is a TTY (#437)

* Don't pass --no-ansi to rm

When --force is used, rm is part of $commands.

rm something --no-ansi succeeds on macOS but fails on Linux.

* Properly check if output is a TTY

This now matches the check setTty() does.

Previously we were only checking the directory separator
and that /dev/tty exists and is readable.

isTtySupported() checks if /dev/tty is *writable* and more
importantly that STDOUT itself is a TTY.

Simply running `laravel new --stuff foo | head` would produce TTY warns
on systems where /dev/tty exists just fine and only stdout is piped.

Author: stancl

src/NewCommand.php

@@ -908,7 +908,7 @@ protected function runCommands($commands, InputInterface $input, OutputInterface
     {
         if (! $output->isDecorated()) {
             $commands = array_map(function ($value) {
-                if (Str::startsWith($value, ['chmod', 'git', $this->phpBinary().' ./vendor/bin/pest'])) {
+                if (Str::startsWith($value, ['chmod', 'rm', 'git', $this->phpBinary().' ./vendor/bin/pest'])) {
                     return $value;
                 }
 
@@ -918,7 +918,7 @@ protected function runCommands($commands, InputInterface $input, OutputInterface
 
         if ($input->getOption('quiet')) {
             $commands = array_map(function ($value) {
-                if (Str::startsWith($value, ['chmod', 'git', $this->phpBinary().' ./vendor/bin/pest'])) {
+                if (Str::startsWith($value, ['chmod', 'rm', 'git', $this->phpBinary().' ./vendor/bin/pest'])) {
                     return $value;
                 }
 
@@ -928,7 +928,7 @@ protected function runCommands($commands, InputInterface $input, OutputInterface
 
         $process = Process::fromShellCommandline(implode(' && ', $commands), $workingPath, $env, null, null);
 
-        if ('\\' !== DIRECTORY_SEPARATOR && file_exists('/dev/tty') && is_readable('/dev/tty')) {
+        if (Process::isTtySupported()) {
             try {
                 $process->setTty(true);
             } catch (RuntimeException $e) {