Don't ignore other kinds of error coming out of execute_process

For example, the old code ignores serde errors

Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>

Author: hbina

src/main.rs

@@ -54,25 +54,25 @@ fn calculate_lsp_params(params: Value) -> Result<LspParams> {
         });
 
     if let Some(server_path) = server_path {
-        let program = match std::env::var("VOLT_OS").as_deref() {
+        let program = match VoltEnvironment::operating_system().as_deref() {
             Ok("windows") => "where",
             _ => "which",
         };
-        let exists = PLUGIN_RPC
+        return match PLUGIN_RPC
             .execute_process(program.to_string(), vec![server_path.to_string()])
             .map(|r| r.success)
-            .unwrap_or(false);
-        if !exists {
-            return Err(anyhow!(
+        {
+            Ok(true) => Ok((
+                Url::parse(&format!("urn:{server_path}"))?,
+                Vec::new(),
+                document_filters,
+                params.initialization_options,
+            )),
+            Ok(false) => Err(anyhow!(
                 "Cannot find the LSP binary at the server path provided. Please check."
-            ));
-        }
-        return Ok((
-            Url::parse(&format!("urn:{server_path}"))?,
-            Vec::new(),
-            document_filters,
-            params.initialization_options,
-        ));
+            )),
+            Err(err) => Err(anyhow!("Unable to execute command because {}", err)),
+        };
     }
 
     let arch = match VoltEnvironment::architecture().as_deref() {
@@ -124,11 +124,9 @@ impl LapcePlugin for State {
     fn handle_request(&mut self, id: u64, method: String, params: Value) {
         #[allow(clippy::single_match)]
         match method.as_str() {
-            Initialize::METHOD => match calculate_lsp_params(params) {
-                Ok((server_uri, args, filters, params)) => {
-                    PLUGIN_RPC
-                        .start_lsp(server_uri, args, filters, params)
-                        .unwrap();
+            Initialize::METHOD => match calculate_lsp_params(params.clone()) {
+                Ok((uri, args, filters, params)) => {
+                    PLUGIN_RPC.start_lsp(uri, args, filters, params).unwrap();
                     PLUGIN_RPC
                         .host_success(id, InitializeResult::default())
                         .unwrap()