From f0ba506ba361df08cad4a4feb2a40e9a12a9854f Mon Sep 17 00:00:00 2001 From: A Brooks Date: Wed, 20 Oct 2021 11:55:47 -0500 Subject: [PATCH 1/2] Increase tests for RE2 property-based test. --- test/lambdaisland/regal/re2_test.clj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/lambdaisland/regal/re2_test.clj b/test/lambdaisland/regal/re2_test.clj index 6f26c84..67e6986 100644 --- a/test/lambdaisland/regal/re2_test.clj +++ b/test/lambdaisland/regal/re2_test.clj @@ -28,7 +28,7 @@ (catch Exception _ false))) -(defspec re2-matches-like-java 10 +(defspec re2-matches-like-java 100 (with-redefs [regal-spec/token-gen #(s/gen (disj regal-spec/known-tokens :line-break :start :end))] (prop'/for-all [regal (s/gen ::regal/form) :when (can-generate? regal) From 1c99b4fca3f035a910c63cada03a7507548e3d71 Mon Sep 17 00:00:00 2001 From: Alys Brooks Date: Tue, 2 Nov 2021 21:49:38 -0500 Subject: [PATCH 2/2] Catch StackOverflowErrors. --- test/lambdaisland/regal/re2_test.clj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/lambdaisland/regal/re2_test.clj b/test/lambdaisland/regal/re2_test.clj index 67e6986..bed2f09 100644 --- a/test/lambdaisland/regal/re2_test.clj +++ b/test/lambdaisland/regal/re2_test.clj @@ -37,6 +37,8 @@ :let [java-result (try (re-find (regal/regex regal) s) (catch Exception _ + :fai) + (catch StackOverflowError _ :fail))] :when (not= :fail java-result)] (is (= java-result