Python3_PhaseMatrixQuickSyn: Conversion to and from bytestrings on connection.write() and connection.readline()

Author: chrisjbillington

PhaseMatrixQuickSyn.py

@@ -216,11 +216,11 @@ def init(self):
         self.connection.readlines()
 
         #check to see if the reference is set to external. If not, make it so! (should we ask the user about this?)
-        self.connection.write('ROSC:SOUR?\r')
-        response = self.connection.readline()
+        self.connection.write(b'ROSC:SOUR?\r')
+        response = self.connection.readline().decode('utf8')
         if response == 'INT\n':
             #ref was set to internal, let's change it to ext
-            self.connection.write('ROSC:SOUR EXT\r')
+            self.connection.write(b'ROSC:SOUR EXT\r')
 
     def check_remote_values(self):
         # Get the currently output values:
@@ -230,12 +230,12 @@ def check_remote_values(self):
         count = 0
 
 
-        self.connection.write('FREQ?\r')
-        line = self.connection.readline()
+        self.connection.write(b'FREQ?\r')
+        line = self.connection.readline().decode('utf8')
 
         if line == '':
             #try again
-            line = self.connection.readline()
+            line = self.connection.readline().decode('utf8')
             if line == '':
                 raise Exception("Device didn't say what its frequncy was :(")
 
@@ -244,8 +244,8 @@ def check_remote_values(self):
 
         # wait a little while first, it doesn't like being asked things too quickly!
         time.sleep(0.05)
-        self.connection.write('OUTP:STAT?\r')
-        line = self.connection.readline()
+        self.connection.write(b'OUTP:STAT?\r')
+        line = self.connection.readline().decode('utf8')
         if line == '':
             raise Exception("Device didn't say what its status was :(")
         time.sleep(0.05)    
@@ -260,8 +260,8 @@ def check_remote_values(self):
     def check_status(self):
         results = {}
         line = ''
-        self.connection.write('STAT?\r')
-        line = self.connection.readline()
+        self.connection.write(b'STAT?\r')
+        line = self.connection.readline().decode('utf8')
         if line == '':
             raise Exception("Device didn't say what its status was :(")
         time.sleep(0.05)    
@@ -295,8 +295,8 @@ def check_status(self):
         results['lock_recovery'] = int(status[-8])
 
         # now let's check it's temperature!
-        self.connection.write('DIAG:MEAS? 21\r')
-        results['temperature'] = float(self.connection.readline())
+        self.connection.write(b'DIAG:MEAS? 21\r')
+        results['temperature'] = float(self.connection.readline().decode('utf8'))
 
         # check if the temperature is bad, if it is, raise an exception. Hopefully one day this will be sent to syslog,
         #at which point we'll add some extra magic to segregate into warning and critical temperatures.
@@ -312,15 +312,15 @@ def program_manual(self,front_panel_values):
         #program in millihertz:
         freq*=1e3
         command = 'FREQ %i\r'%freq
-        self.connection.write(command)
+        self.connection.write(command.encode('utf8'))
 
         # add some sleep time here since the phasematrix gets grumpy
         time.sleep(0.05)
 
 
         gate = front_panel_values['dds 0']['gate']
         command = 'OUTP:STAT %i\r'%gate
-        self.connection.write(command)
+        self.connection.write(command.encode('utf8'))
 
         return self.check_remote_values()
 
@@ -345,9 +345,9 @@ def transition_to_buffered(self,device_name,h5file,initial_values,fresh):
             if 'STATIC_DATA' in group:
                 data = group['STATIC_DATA'][:][0]
 
-        self.connection.write('FREQ %i\r'%(data['freq0']))
+        self.connection.write(b'FREQ %i\r'%(data['freq0']))
         time.sleep(0.05)
-        self.connection.write('OUTP:STAT 1')#%i'%(data['gate0']))
+        self.connection.write(b'OUTP:STAT 1')#%i'%(data['gate0']))
 
 
         # Save these values into final_values so the GUI can