[Bug]: cmake downloads the internet during build

[dvzrv]

What happened?

Hi! 👋

When trying to build 1.0.0 for Arch Linux, I noticed that cmake downloads the internet, if it doesn't find the exact JUCE version:

element/cmake/FindJUCE.cmake

Lines 17 to 24 in 73d9f52

	else()
	FetchContent_Declare(juce
	GIT_REPOSITORY https://github.com/juce-framework/JUCE.git
	GIT_TAG ${ELEMENT_JUCE_VERSION}
	GIT_SHALLOW ON)
	FetchContent_Populate(juce)
	add_subdirectory(${juce_SOURCE_DIR} ${juce_BINARY_DIR} EXCLUDE_FROM_ALL)
	endif()

This is somewhat problematic, as Linux distributions usually want to build offline, after locking and retrieving specific source inputs.

Also: Would it be possible to not require a specific version, but a minimum or something like that?

Version

1.0.0 (Latest)

Relevant log output

n/a

[mfisher31]

Exact version of juce is how it has to be unfortunately. The JUCE config cmake files use the ExactVersion strategy in cmake. Unless there's another way to do it, we're stuck with what juce gives us.

[dvzrv]

Exact version of juce is how it has to be unfortunately.

I see. 🥲

However, then a git submodule for juce would be the cleaner choice here, as it clearly points at juce being a build time dependency (in a specific version).
Downloading during build is not a good choice for this.