fix(loadbalancer): Move deletion of security groups before lb delete

Author: nicolaiort

pkg/openstack/loadbalancer.go

@@ -2151,6 +2151,12 @@ func (lbaas *LbaasV2) ensureLoadBalancerDeleted(ctx context.Context, clusterName
 		}
 	}
 
+	// Delete the Security Group. We're doing that even if `manage-security-groups` is disabled to make sure we don't
+	// orphan created SGs even if CPO got reconfigured.
+	if err := lbaas.ensureSecurityGroupDeleted(ctx, service); err != nil {
+		return err
+	}
+
 	if err = lbaas.deleteLoadBalancer(ctx, loadbalancer, service, svcConf, needDeleteLB); err != nil {
 		return err
 	}
@@ -2174,12 +2180,6 @@ func (lbaas *LbaasV2) ensureLoadBalancerDeleted(ctx context.Context, clusterName
 		klog.InfoS("Updated load balancer tags", "lbID", loadbalancer.ID)
 	}
 
-	// Delete the Security Group. We're doing that even if `manage-security-groups` is disabled to make sure we don't
-	// orphan created SGs even if CPO got reconfigured.
-	if err := lbaas.ensureSecurityGroupDeleted(ctx, service); err != nil {
-		return err
-	}
-
 	return nil
 }