cinder-csi: make csi-snapshotter sidecar optional

The csi-snapshotter sidecar is always deployed regardless of whether
the VolumeSnapshot CRDs are installed. On clusters without the
external-snapshotter CRDs, this produces continuous error logs from the
sidecar attempting to list VolumeSnapshotContent resources that don't
exist.

Add csi.snapshotter.enabled (default true for backward compatibility)
to gate the snapshotter container and its RBAC resources.

Author: 234u34k

charts/cinder-csi-plugin/templates/controllerplugin-deployment.yaml

@@ -86,6 +86,7 @@ spec:
             - name: socket-dir
               mountPath: /var/lib/csi/sockets/pluginproxy/
           resources: {{ toYaml .Values.csi.provisioner.resources | nindent 12 }}
+        {{- if .Values.csi.snapshotter.enabled }}
         - name: csi-snapshotter
           securityContext:
             {{- toYaml .Values.csi.plugin.controllerPlugin.securityContext | nindent 12 }}
@@ -111,6 +112,7 @@ spec:
             - mountPath: /var/lib/csi/sockets/pluginproxy/
               name: socket-dir
           resources: {{ toYaml .Values.csi.snapshotter.resources | nindent 12 }}
+        {{- end }}
         - name: csi-resizer
           securityContext:
             {{- toYaml .Values.csi.plugin.controllerPlugin.securityContext | nindent 12 }}

charts/cinder-csi-plugin/templates/controllerplugin-rbac.yaml

@@ -88,6 +88,7 @@ roleRef:
   name: csi-provisioner-role
   apiGroup: rbac.authorization.k8s.io
 
+{{- if .Values.csi.snapshotter.enabled }}
 ---
 kind: ClusterRole
 apiVersion: rbac.authorization.k8s.io/v1
@@ -125,6 +126,7 @@ roleRef:
   kind: ClusterRole
   name: csi-snapshotter-role
   apiGroup: rbac.authorization.k8s.io
+{{- end }}
 ---
 kind: ClusterRole
 apiVersion: rbac.authorization.k8s.io/v1

charts/cinder-csi-plugin/values.yaml

@@ -23,6 +23,7 @@ csi:
     extraArgs: {}
     extraEnv: []
   snapshotter:
+    enabled: true
     image:
       repository: registry.k8s.io/sig-storage/csi-snapshotter
       tag: v8.4.0