Skip to content

Commit 3f178a7

Browse files
authored
Upgrade Microsoft.Rest.ClientRuntime from 2.3.10 to 2.3.23 (#702)
* Upgrade Microsoft.Rest.ClientRuntime from 2.3.10 to 2.3.23 (#699) * Fix unit tests by setting kubernetesMock.CallBase = true (#699)
1 parent 463e2d9 commit 3f178a7

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/KubernetesClient/KubernetesClient.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<PackageReference Include="Fractions" Version="4.0.1" />
3535
<PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" PrivateAssets="all" />
3636
<PackageReference Include="Portable.BouncyCastle" Version="1.8.1.3" />
37-
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.10" />
37+
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.23" />
3838
<PackageReference Include="prometheus-net" Version="4.1.1" />
3939
<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="6.11.1" />
4040
<PackageReference Include="System.IO.Abstractions" Version="13.2.33" />

tests/KubernetesClient.Tests/PodExecTests.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ public async Task NamespacedPodExecAsyncActionNull()
191191
muxedStream.Setup(m => m.GetStream(ChannelIndex.Error, null)).Returns(errorStream);
192192

193193
var kubernetesMock = new Moq.Mock<Kubernetes>(
194-
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
194+
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } })
195+
{ CallBase = true };
195196
var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
196197

197198
kubernetesMock.Setup(m => m.MuxedStreamNamespacedPodExecAsync("pod-name", "pod-namespace", command,
@@ -213,7 +214,8 @@ await Assert.ThrowsAsync<ArgumentNullException>(() => client.NamespacedPodExecAs
213214
public async Task NamespacedPodExecAsyncHttpExceptionWithStatus()
214215
{
215216
var kubernetesMock = new Moq.Mock<Kubernetes>(
216-
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
217+
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } })
218+
{ CallBase = true };
217219
var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
218220
var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
219221

@@ -237,7 +239,8 @@ public async Task NamespacedPodExecAsyncHttpExceptionWithStatus()
237239
public async Task NamespacedPodExecAsyncHttpExceptionNoStatus()
238240
{
239241
var kubernetesMock = new Moq.Mock<Kubernetes>(
240-
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
242+
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } })
243+
{ CallBase = true };
241244
var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
242245
var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
243246

@@ -260,7 +263,8 @@ public async Task NamespacedPodExecAsyncHttpExceptionNoStatus()
260263
public async Task NamespacedPodExecAsyncGenericException()
261264
{
262265
var kubernetesMock = new Moq.Mock<Kubernetes>(
263-
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
266+
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } })
267+
{ CallBase = true };
264268
var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
265269
var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
266270

@@ -313,7 +317,8 @@ public async Task NamespacedPodExecAsyncExitCodeNonZero()
313317
muxedStream.Setup(m => m.GetStream(ChannelIndex.Error, null)).Returns(errorStream);
314318

315319
var kubernetesMock = new Moq.Mock<Kubernetes>(
316-
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
320+
new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } })
321+
{ CallBase = true };
317322
var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
318323

319324
var exception = new Exception();

0 commit comments

Comments
 (0)