Inconsistent singular vs. plural unit naming in generated factories

[matt-edmondson]

Summary

Generated From{Unit} factories mix singular and plural forms across dimensions, which is jarring for consumers and inconsistent with the documented API surface.

Evidence

From Semantics.Quantities/Generated/.../*.g.cs:

File	Generated factory
Mass.g.cs	FromKilogram (singular)
Force1D.g.cs	FromNewton (singular)
Distance.g.cs	FromMeter (singular)
Diameter.g.cs	FromMeter (singular)
Airspeed.g.cs	FromMetersPerSecond (plural)
Acceleration1D.g.cs	FromMetersPerSecondSquared (plural)
AngularMomentum1D.g.cs	FromKilogramMeterSquaredPerSecond (singular composite)

Meanwhile the strategy doc (docs/strategy-unified-vector-quantities.md) advertises Speed.FromMetersPerSecond(...) and Force1D.FromNewtons(...) (plural).

Impact

• API surface differs from documentation.
• Calling code must guess which form a given unit uses.

Suggested next step

Pick a single convention (recommended: plural for all units, since most values are quantities) and update the unit metadata / generator so every emitted factory uses it. Add a unit test (or generator snapshot) that asserts the convention across all generated quantities.

Area / Severity

SourceGenerators · cleanup

[matt-edmondson]

Status check, not closing.

Naming inconsistency is unchanged after #70. Recommend bundling the fix with #48 because the single change is "the generator emits From{factoryName} for every entry in availableUnits." Concrete proposal:

• Add an optional factoryName string to UnitDefinition in units.json.
• Default = unit name + s (covers Newton→Newtons, Kilogram→Kilograms, Joule→Joules).
• Override for compound units that already read as plural (MetersPerSecond → MetersPerSecond) and irregular forms (Foot → Feet, Inch → Inches, Hertz → Hertz).
• Generator reads units.json and emits public static {Quantity}<T> From{factoryName}(T value) => Create({conversion}(value)); for each unit in the dimension's availableUnits.

This is the convention CLAUDE.md and docs/strategy-unified-vector-quantities.md already advertise (FromMetersPerSecond, FromNewtons).

---

Generated by Claude Code