Skip to content

Compilation error on Ember CLI 1.13 #6

@a76-zz

Description

@a76-zz

Hello,
I have the following issue during compilation:

version: 1.13.8
Build failed.
File: orion/controllers/application.em
Ember is not defined
ReferenceError: Ember is not defined
at get (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/ember-runtime.js:1924:3)
at Array.Ember.Enumerable.Ember.Mixin.create.find (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/ember-runtime.js:8129:15)
at class$.exports.Compiler.cache$2 (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:1109:41)
at class$. (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2437:86)
at class$.exports.Compiler.Compiler.compile.walk (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2349:19)
at class$. (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2335:27)
at class$.exports.Compiler.Compiler.compile.walk (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2340:11)
at class$. (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2335:27)
at class$.exports.Compiler.Compiler.compile.walk (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2340:11)
at class$.exports.Compiler.Compiler.compile.walk (/home/andrei/ember/orion/node_modules/ember-cli-emberscript/node_modules/broccoli-ember-script/node_modules/ember-script/lib/compiler.js:2340:68)

The issue can be fixed if comment line ember-runtime.js:1924:
//Ember.assert("You need to provide an object and key to get.", !!obj && keyName);

If try to use computed property 'Ember is not defined' error emerges again in the other place - compiler.js.
The issue can be fixed if do the following comment but it is only dirty fix due to uniq() function not running:
chains = /*Ember.A(*/this.dependentKeys().map(function (c) { return c.join('.'); })/*).uniq()*/; return emberComputedProperty(fn, chains); } else {...

Whether Ember.A function usage is correct in the compiler.js? It seems it is the single place of usage Ember in this file.

Could you please explain the reason of such mistake and describe how correct them more natural?
Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions