Skip to content

Commit 248911c

Browse files
committed
add comments for bug fixes
1 parent d820c3c commit 248911c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

GEMstack/onboard/perception/pedestrian_detection.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ def find_vels(self, track_ids: List[int], obj_centers: List[np.ndarray]) -> Dict
163163
def viz_object_states(self, cv_image, boxes, extracted_pts_all):
164164
# Extract 3D pedestrians points in lidar frame
165165
# ** These are camera frame after transform_lidar_points, right?
166+
# ** It was in camera frame before. I fixed it. Now they are in lidar frame!
166167
pedestrians_3d_pts = [list(extracted_pts[:, -3:]) for extracted_pts in extracted_pts_all]
167168

168169
# Object center viz
@@ -232,6 +233,7 @@ def update_object_states(self, track_result: List[Results], extracted_pts_all: L
232233

233234
# Extract 3D pedestrians points in lidar frame
234235
# ** These are camera frame after transform_lidar_points, right?
236+
# ** It was in camera frame before. I fixed it. Now they are in lidar frame!
235237
pedestrians_3d_pts = [list(extracted_pts[:, -3:]) for extracted_pts in extracted_pts_all]
236238
if len(pedestrians_3d_pts) != num_objs:
237239
raise Exception('Perception - Camera detections, points clusters num. mismatch')
@@ -326,7 +328,6 @@ def ouster_oak_callback(self, rgb_image_msg: Image, lidar_pc2_msg: PointCloud2):
326328
extracted_pts_all.append(extracted_pts)
327329
else: extracted_pts_all.append(np.array(()))
328330

329-
#if len(extracted_pts_all) > 0 and len(track_result) > 0:
330331
self.update_object_states(track_result, extracted_pts_all)
331332
if self.debug: self.viz_object_states(cv_image, boxes, extracted_pts_all)
332333

0 commit comments

Comments
 (0)