Review issues and PRs in original rickfast/consul-client

[sleberknight]

Review the issues and open PRs in the original consul-client library to see if there is anything there that we should address.

[sleberknight]

Issues:

There were 38 open issues when the repository was archived. These are ordered from Newest to Oldest, as shown in the issue list.

Issue	Title	Resolution	Notes
473	ServiceHealth deserialize failed	Won't Fix	There is a test for this and it passes, so ignoring this report. It doesn't make sense that a service would not have a port.
469	Open CVEs against consul-client 1.5.3	Fixed	We have updated well beyond all the versions with CVEs
462	Update okhttp to version 4.9.2	Fixed	We are using version 4.11.0
458	Recurse to false in delete options not working	Fixed	The report appears valid. Created #263
457	com.orbitz.consul.ConsulException: Consul cluster has no elected leader	Fixed	Pretty sure this was fixed by rickfast/consul-client#456 as noted in the comments
452	Support streaming endpoint /v1/health/service/:serviceName?cached	Fixed	As noted in the comment, it is fixed by rickfast/consul-client#405
451	checkWatch networkReadMillis < cacheWatchSeconds ?	Won't Fix	Not a bug - the guard is intentional, the read timeout must be greater than the watch interval
443	Fails to retrieve keyValue in folder by key	Fixed	Not an issue anymore. Created #266 to detect future regressions
423	Why do two callbacks happen?	Won't Fix	I don't think this is an actual issue
422	How to consume a rest service with this client?	Won't Fix	The doesn't even make sense. This is a client for Consul, not a generic REST service.
421	API ping() uses an endpoint that is secured by ACLs	Fixed	This was fixed by rickfast/consul-client#446
416	No releaseLock method exposed in the KV Client to preserve the existing value	Fixed	Added method that allows releasing the lock and updating the key's value.
415	the AgentClient.java code bug	Fixed	Was fixed by https://github.com/rickfast/consul-client/pull/445/files
414	AgentClient.registerCheck throw exception with message Request decode failed: json: unknown field "Output" after migration to consul 1.7.1	Fixed	Was fixed by rickfast/consul-client#411
412	How to include shaded version in pom	Won't Fix	Not an issue anymore, since only a single, shaded JAR is released
407	Upgrade dependency to Jackson 2.10.x	Fixed	We are now using Jackson 2.15.2
401	QueryOptions didn't contain filter option	Fixed	Fixed by rickfast/consul-client#447
394	Http connection refused error with Consul client	Won't Fix	Not enough detail about the error, and not going to pursue the other questions about additional logging, etc.
393	Subscribe to a leader change (re-election)	Won't Fix	We don't have any similar requirement
392	Extract an interface from the Consul class	Won't Fix	No. Just no.
387	ConsulCache creates new executor service for every service in ServiceHealthCache.	Fixed	Fixed by rickfast/consul-client#396
380	Watch on service list	Won't Fix	Based on Rick Fast's comment on this, doesn't make sense
378	why is there no AgentClient getService(serviceId) method using GET/agent/service/:service_id?	Won't Fix	This already exists: AgentClient.getService(id, queryOptions)
376	Non blocking health check support	Won't Fix	ConsistencyMode already has createCachedConsistencyWithMaxAgeAndStale which adds the ?cached query parameter and Cache-Control headers
372	How can I define timeout in session lock? Can the session lock cross datacenter?	Won't Fix	Not worth trying to understand, and not sure if it's really an issue anyway
368	Need info: Do you support clustering/HA related operations?	Won't Fix	This is a question that doesn't need answering
363	Why is there no support for agent/connect API?	Won't Fix	As Rick says, it was a new feature and PRs welcome...of course, the person who submitted wasn't going to do any work to help out, just expect people to do it for them...
358	Add NodeMeta in the CatalogRegistration	Fixed	Fixed by rickfast/consul-client#386
356	Shaded Jar brings in excluded dependencies	Fixed	Was some kind of IDE issue
355	undesired url-encoding of nested keys in kv	Fixed	This is the same as rickfast/consul-client#443 and is not an issue anymore. The tests in #266 prove you can get a key like /foo/bar
330	Does consul-client support custom user event?	Won't Fix	Not needed
326	Exception in thread "main" java.lang.NoSuchMethodError: okhttp3.Interceptor$Chain.readTimeoutMillis()	Won't Fix	Pretty sure this was user error, and we would certainly have noticed if we could not register services with Consul
282	AgentClient.ping: "java.io.EOFException: \n not found: size=0 content=…"	Won't Fix	Cannot reproduce and don't think this was ever a real issue. Add some sanity check tests in #268
266	shaded consul-client shouldn't include Guava transitive dependencies	Won't Fix	This is not an issue anymore
259	How do I "restart" watching Key-Value	Fixed	This seems to be fixed by rickfast/consul-client#467 but will need testing. Fixed it in #548
235	Add automatic deregistration option	Fixed	As comments say this already exists
201	AgentClient.pass() always throws com.orbitz.consul.NotRegisteredException	Won't Fix	Not a bug, but updated Javadocs of pass, warn, fail, etc. to clarify how it works, and to reference the passCheckl, warnCheck, failCheck methods as the ones to use for custom CheckID
180	consul health client timeout	Won't Fix	Per the very last comment it wasn't really an issue

Pull Requests:

There were 10 pull requests when the repository was archived. These are ordered from Newest to Oldest, as show in the PRs list.

Issue	Title	Resolution	Notes
472	Fix breaking test and upgrade TestContainers for M1 support	Fixed	Fixed by #12
471	Bump jackson-databind from 2.12.0 to 2.12.7.1	Fixed	We are on Jackson 2.15.2
467	client builder with token producer; allow reload of new token after its expiration	Fixed	It looks like this PR will actually solve rickfast/consul-client#259, though it will need some tests and verification. Added by #548
465	Upgraded com.squareup.okhttp3:okhttp	Fixed	This PR updates to 4.10.0; we are on 4.11.0
464	HH-157725 add path and responseCode parameters to ClientEventCallback interface methods	Needs Evaluation	This deprecates public APIs
463	updated dependencies with open CVEs	Fixed	We are on latest version of guava, Jackson, OkHttp, and Logback
461	Add test for ConsulResponse.toString	Won't Fix	Not needed
454	start cache from specific index	Won't Fix	Niche use case, adds complexity, so won't do this one
453	Timeout validation remove	Needs Evaluation	Changes 18 files, and referenced by rickfast/consul-client#451 as a fix. Need to look closely and understand the PR.
403	Bump jackson.version from 2.9.10 to 2.10.1	Fixed	We're on Jackson 2.15.2