This LinkViewHelper.php strongly needs refactoring. It silently ignores additional params and surpasses fluid ViewHelper logic. I know it was a quickly needed, hard to sort out and complex Bugfix. And @markusweigelt did a great Job, figuring out the deep routing stack in TYPO3.
But it needs optimization or replacement in the future.
And an idea, how we tackle this issue: https://forge.typo3.org/issues/107026
Originally posted by @fschoelzel in #1819 (comment)
See also this comment by @markusweigelt:
Thx for your analysis. There are definitely a few smaller details that still need adjustment. I actually missed the title attribute in my DFG-Viewer and Kitodo.Presentation test cases 🥲
Regarding the current implementation:
Extending https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
is unfortunately not an option, since the ViewHelper is marked as final, which makes it impossible to properly access or override the internal logic. Various approaches in different direction have already been tried (see also https://forge.typo3.org/issues/107026)
Using a custom ViewHelper also had some positive side effects:
The frontend complexity has been significantly reduced slub/slub_digitalcollections@24083c3 and beside we were also able to get rid of addQueryString="untrusted", which is not recommended anyway (cause it inflates the URL with unnecessary parameters).
I’m looking forward to an improved solution and feel free to keep me posted 😉
This LinkViewHelper.php strongly needs refactoring. It silently ignores additional params and surpasses fluid ViewHelper logic. I know it was a quickly needed, hard to sort out and complex Bugfix. And @markusweigelt did a great Job, figuring out the deep routing stack in TYPO3.
But it needs optimization or replacement in the future.
And an idea, how we tackle this issue: https://forge.typo3.org/issues/107026
Originally posted by @fschoelzel in #1819 (comment)
See also this comment by @markusweigelt: