Skip to content

Commit 058de86

Browse files
authored
Merge pull request #45 from kimkulling/review/explicit_ctr
Add explicit constructors
2 parents 5a5f2a8 + 11f2f20 commit 058de86

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

include/cppcore/Common/TBitField.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class TBitField {
4141

4242
/// @brief The class constructor with the initial value.
4343
/// @param[in] init The init value.
44-
TBitField(T init);
44+
explicit TBitField(T init);
4545

4646
/// @brief The class destructor.
4747
~TBitField() = default;

include/cppcore/Common/TOptional.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class TOptional {
3737
public:
3838
/// @brief The class constructor.
3939
/// @param[in] defaultValue Init value if no set was performed.
40-
TOptional(T defaultValue);
40+
explicit TOptional(T defaultValue);
4141

4242
/// @brief The class destructor.
4343
~TOptional() = default;

include/cppcore/Common/TStringBase.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ inline size_t TStringBase<T>::size() const {
131131

132132
template <class T>
133133
inline bool TStringBase<T>::isEmpty() const {
134-
return (mSize == 0);
134+
return mSize == 0;
135135
}
136136

137137
template <class T>
@@ -220,6 +220,9 @@ inline TStringBase<T>& TStringBase<T>::operator+=(char c) {
220220

221221
template <class T>
222222
inline T TStringBase<T>::operator[](size_t index) const {
223+
if (index >= mSize) {
224+
return 0;
225+
}
223226
return mBuffer[index];
224227
}
225228

0 commit comments

Comments
 (0)