Issue: Notify Pending Transaction State Change in Adyen Plugin
Description
While reviewing the Kill Bill Janitor documentation, I noticed that the Kill Bill API can be used to check the state of pending transactions.
In the AdyenPaymentPluginApi.java file at the following location:
AdyenPaymentPluginApi.java#L610,
we could notify Kill Bill about the state change by adding the following code:
try{
final Account kbAccount = killbillAPI
.getAccountUserApi()
.getAccountById(UUID.fromString(record.getKbAccountId()), tempContext);
this.killbillAPI
.getPaymentApi()
.notifyPendingTransactionOfStateChanged(
kbAccount,
UUID.fromString(record.getKbPaymentTransactionId()),
notificationItem.isSuccess(),
tempContext);
} catch (Exception e) {
logger.error("Error Notifying state change {}", e.getMessage(), e);
}
Expected Behavior
Ensure that the plugin properly informs Kill Bill about the state change of pending transactions.
Reduce inconsistencies by leveraging the Kill Bill API's existing functionality.
Suggested Resolution
Please review and consider implementing this change to enhance transaction state handling in the Adyen plugin.
Thank you!
Issue: Notify Pending Transaction State Change in Adyen Plugin
Description
While reviewing the Kill Bill Janitor documentation, I noticed that the Kill Bill API can be used to check the state of pending transactions.
In the
AdyenPaymentPluginApi.javafile at the following location:AdyenPaymentPluginApi.java#L610,
we could notify Kill Bill about the state change by adding the following code:
Expected Behavior
Ensure that the plugin properly informs Kill Bill about the state change of pending transactions.
Reduce inconsistencies by leveraging the Kill Bill API's existing functionality.
Suggested Resolution
Please review and consider implementing this change to enhance transaction state handling in the Adyen plugin.
Thank you!