feat(web): add quotientPathHasInputs tests for SearchQuotientClusters

Author: jahorton

web/src/test/auto/headless/engine/predictive-text/worker-thread/correction-search/search-cluster.tests.ts

@@ -116,19 +116,19 @@ export const buildAlphabeticClusterFixtures = () => {
 
   return {
     distributions: {
-      0: {
+      1: {
         distrib_c1_i1d0,
         distrib_c1_i2d0
       },
-      1: {
+      2: {
         distrib_v1_i1d0
       },
-      2: {
+      3: {
         distrib_v2_i1d0,
         distrib_v2_i1d1,
         distrib_v2_i2d1
       },
-      3: {
+      4: {
         distrib_c2_i1d0,
         distrib_c2_i2d0
       }
@@ -172,7 +172,7 @@ export const buildAlphabeticClusterFixtures = () => {
 
 describe('SearchCluster', () => {
   describe('constructor()', () => {
-    it('initializes from root SearchPath', () => {
+    it('initializes from LegacySearchRoot', () => {
       const path = new LegacyQuotientRoot(testModel);
       const cluster = new SearchQuotientCluster([path]);
       assert.equal(cluster.inputCount, 0);
@@ -182,7 +182,7 @@ describe('SearchCluster', () => {
       assert.deepEqual(cluster.parents, [path]);
     });
 
-    it('initializes from arbitrary SearchPath', () => {
+    it('initializes from arbitrary SearchQuotientSpur', () => {
       const rootPath = new LegacyQuotientRoot(testModel);
 
       const leadEdgeDistribution: Distribution<Transform> = [
@@ -228,11 +228,11 @@ describe('SearchCluster', () => {
       ]);
     });
 
-    it('throws an error when SearchPath array is empty', () => {
+    it('throws an error when constructor array parameter is empty', () => {
       assert.throws(() => new SearchQuotientCluster([]));
     });
 
-    it('throws an error if SearchPath .inputCount values don\'t match', () => {
+    it('throws an error if parent .inputCount values don\'t match', () => {
       const rootPath = new LegacyQuotientRoot(testModel);
 
       const leadEdgeDistribution: Distribution<Transform> = [

web/src/test/auto/headless/engine/predictive-text/worker-thread/correction-search/search-quotient-node.tests.ts

@@ -6,6 +6,7 @@ import { LegacyQuotientRoot, models, quotientPathHasInputs } from '@keymanapp/lm
 import { buildSimplePathSplitFixture } from './search-quotient-spur.tests.js';
 
 import TrieModel = models.TrieModel;
+import { buildAlphabeticClusterFixtures } from './search-cluster.tests.js';
 
 const testModel = new TrieModel(jsonFixture('models/tries/english-1000'));
 
@@ -48,5 +49,38 @@ describe('quotientNodeHasParents()', () => {
     } while(!isShuffled);
     assert.isFalse(quotientPathHasInputs(paths[4], shuffled));
   });
+
+  it('is able to match inputs against SearchQuotientCluster constituent input paths', () => {
+    const { distributions, clusters } = buildAlphabeticClusterFixtures();
+
+    const fourCharCluster = clusters.cluster_k4c4;
+    const fiveCharCluster = clusters.cluster_k4c5;
+
+    assert.isTrue(quotientPathHasInputs(fourCharCluster, [
+      distributions[1].distrib_c1_i1d0,
+      distributions[2].distrib_v1_i1d0,
+      distributions[3].distrib_v2_i1d0,
+      distributions[4].distrib_c2_i1d0
+    ]));
+    assert.isFalse(quotientPathHasInputs(fiveCharCluster,[
+      distributions[1].distrib_c1_i1d0,
+      distributions[2].distrib_v1_i1d0,
+      distributions[3].distrib_v2_i1d0,
+      distributions[4].distrib_c2_i1d0
+    ]));
+
+    assert.isFalse(quotientPathHasInputs(fourCharCluster, [
+      distributions[1].distrib_c1_i1d0,
+      distributions[2].distrib_v1_i1d0,
+      distributions[3].distrib_v2_i1d0,
+      distributions[4].distrib_c2_i2d0
+    ]));
+    assert.isTrue(quotientPathHasInputs(fiveCharCluster, [
+      distributions[1].distrib_c1_i1d0,
+      distributions[2].distrib_v1_i1d0,
+      distributions[3].distrib_v2_i1d0,
+      distributions[4].distrib_c2_i2d0
+    ]));
+  });
 });
 

web/src/test/auto/headless/engine/predictive-text/worker-thread/correction-search/search-quotient-spur.tests.ts

@@ -14,6 +14,8 @@ import { KMWString } from '@keymanapp/web-utils';
 import { jsonFixture } from '@keymanapp/common-test-resources/model-helpers.mjs';
 import { generateSubsetId, LegacyQuotientSpur, models, LegacyQuotientRoot, quotientPathHasInputs, SearchQuotientNode, PathInputProperties, SearchQuotientSpur } from '@keymanapp/lm-worker/test-index';
 
+import { buildAlphabeticClusterFixtures } from './search-cluster.tests.js';
+
 import Distribution = LexicalModelTypes.Distribution;
 import Transform = LexicalModelTypes.Transform;
 import TrieModel = models.TrieModel;
@@ -291,7 +293,22 @@ describe('SearchQuotientSpur', () => {
       assert.sameOrderedMembers(pathSequence, paths.slice(1));
     });
 
-    // TODO:  add a test for mixed SearchQuotientSpur / SearchCluster cases.
+    it('properly enumerates child paths when encountering SearchCluster ancestors', () => {
+      const fixture = buildAlphabeticClusterFixtures();
+      const finalPath = fixture.paths[4].path_k4c6;
+
+      // The longest SearchPath at the end of that fixture's set is based on a
+      // lead-in cluster; all variants of that should be included.
+      assert.equal(finalPath.constituentPaths.length, fixture.clusters.cluster_k3c4.constituentPaths.length);
+
+      // That cluster holds the different potential penultimate paths;
+      // finalPath's inputs are added directly after any variation that may be
+      // output from the cluster.
+      assert.sameDeepMembers(finalPath.constituentPaths, fixture.clusters.cluster_k3c4.constituentPaths.map((p) => {
+        p.push(finalPath);
+        return p;
+      }));
+    });
   });
 
   describe('split()', () => {