Merge pull request #15486 from keymanapp/change/web/remove-node-inputSequence

change(web): remove SearchQuotientNode.inputSequence 🚂

Author: jahorton

web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-node.ts

@@ -178,16 +178,6 @@ export interface SearchQuotientNode {
    */
   readonly inputCount: number;
 
-  /**
-   * Retrieves the sequence of inputs that led to this SearchQuotientNode.
-   *
-   * THIS WILL BE REMOVED SHORTLY in favor of `constituentPaths` below, which
-   * provides an improved view into the data and models multiple paths to the
-   * space when they exist.  (Once SearchQuotientNode takes on merging &
-   * splitting)
-   */
-  readonly inputSequence: Distribution<Transform>[];
-
   /**
    * Reports the length in codepoints of corrected text represented by completed
    * paths from this instance.

web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-root.ts

@@ -47,11 +47,6 @@ export class SearchQuotientRoot implements SearchQuotientNode {
     return [];
   }
 
-  // Return a new array each time; avoid aliasing potential!
-  get inputSequence(): LexicalModelTypes.Distribution<LexicalModelTypes.Transform>[] {
-    return [];
-  }
-
   // Return a new instance each time; avoid aliasing potential!
   get bestExample(): { text: string; p: number; }  {
     return { text: '', p: 1 };

web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-spur.ts

@@ -104,15 +104,6 @@ export abstract class SearchQuotientSpur implements SearchQuotientNode {
     return this.parentNode.model;
   }
 
-  /**
-   * Retrieves the sequences of inputs that led to this SearchPath.
-   */
-  public get inputSequence(): Distribution<Transform>[] {
-    const parentInputs = this.parentNode?.inputSequence.slice() ?? [];
-    const localInputs = this.inputs ? [this.inputs.slice()] : [];
-    return parentInputs.concat(localInputs);
-  }
-
   get codepointLength(): number {
     if(this._codepointLength === undefined) {
       this._codepointLength = this.parentNode.codepointLength + this.insertLength - this.leftDeleteLength;

web/src/test/auto/headless/engine/predictive-text/worker-thread/correction-search/getBestMatches.tests.ts

@@ -106,7 +106,6 @@ describe('getBestMatches', () => {
 
     // Just one suggestion root should be returned as the first result.
     assert.equal(result.totalCost, 0);             // Gives a perfect match
-    assert.equal(result.inputSequence.length, 0);  // for a state with no input and
     assert.equal(result.matchString, '');          // an empty match string.
     assert.isFalse(resultState.done);