no comments (yet)
there doesn't seem to be anything here
there doesn't seem to be anything here
\ No newline at end of file
diff --git a/go/pvl/testdata/reddit-max.xml b/go/pvl/testdata/reddit-max.xml
deleted file mode 100644
index 6c1f2d599e5a..000000000000
--- a/go/pvl/testdata/reddit-max.xml
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/go/pvl/testdata/reddit-terribletext5299.xml b/go/pvl/testdata/reddit-terribletext5299.xml
deleted file mode 100644
index ccab7b4df010..000000000000
--- a/go/pvl/testdata/reddit-terribletext5299.xml
+++ /dev/null
@@ -1 +0,0 @@
- blocks. There may be more than one
- # code block in the post, though (see max's proof), extract and concatenate
- # them all into one register.
+ , error: ["TITLE_NOT_FOUND", "Missing signature ID (%{sig_id_medium}) in post title '%{title}'"] } },
+ # Grab the rendered post body. The signature lives in / blocks
+ # whose newlines are preserved in the HTML, so pulling the whole usertext-body
+ # text into one register is enough to recover a multi-line PGP signature
+ # (see max's proof) as well as single-line NaCl ones.
{ selector_css: {
- , selectors: ["code", { contents: true }]
- , into: "code_raw"
- , multi: true
- , error: ["CONTENT_MISSING", "Could not find content in XML"] } },
- # The content in .rss endpoint is stripped out of newlines. We are going to
- # normalize whitespace and replace all spaces with newlines to recover the
- # matching multiline PGP signature so it matches the `sig` register. This has
- # no effect on NaCl signatures.
- { whitespace_normalize: {
- , from: "code_raw"
- , into: "code_nw" } },
- { replace_all: {
- , old: " "
- , new: "\n"
- , from: "code_nw"
- , into: "code" } },
- # Finally, find the signature in the normalized text.
+ , selectors: ["div.thing.link.self", "div.usertext-body"]
+ , into: "post_body"
+ , error: ["CONTENT_MISSING", "Could not find entry element"] } },
+ # Finally, find the signature in the post body.
{ assert_find_base64: {
, needle: "sig"
- , haystack: "code"
+ , haystack: "post_body"
, error: ["TEXT_NOT_FOUND", "Signature not found in body"] } },
]]
rooter: [[
Want to add to the discussion?
Post a comment!