fix: address remaining cursor[bot] review feedback

1. Fix replays download flag: read "output-file" instead of "output"
2. Return proper exit codes in JSON mode for failures:
   - deploy: return error on failed/stopped deployments
   - invoke: return error on failed invocations
3. Handle acquire timeout in JSON mode:
   - browser-pools acquire: output null instead of pterm warning
   - browsers create (with pool): output null instead of pterm error

Author: rgarcia

cmd/browser_pools.go

@@ -360,6 +360,10 @@ func (c BrowserPoolsCmd) Acquire(ctx context.Context, in BrowserPoolsAcquireInpu
 		return util.CleanedUpSdkError{Err: err}
 	}
 	if resp == nil {
+		if in.Output == "json" {
+			fmt.Println("null")
+			return nil
+		}
 		pterm.Warning.Println("Acquire request timed out (no browser available). Retry to continue waiting.")
 		return nil
 	}

cmd/browsers.go

@@ -2228,6 +2228,10 @@ func runBrowsersCreate(cmd *cobra.Command, args []string) error {
 			return util.CleanedUpSdkError{Err: err}
 		}
 		if resp == nil {
+			if output == "json" {
+				fmt.Println("null")
+				return nil
+			}
 			pterm.Error.Println("Acquire request timed out (no browser available). Retry to continue waiting.")
 			return nil
 		}
@@ -2364,7 +2368,7 @@ func runBrowsersReplaysStop(cmd *cobra.Command, args []string) error {
 func runBrowsersReplaysDownload(cmd *cobra.Command, args []string) error {
 	client := getKernelClient(cmd)
 	svc := client.Browsers
-	out, _ := cmd.Flags().GetString("output")
+	out, _ := cmd.Flags().GetString("output-file")
 	b := BrowsersCmd{browsers: &svc, replays: &svc.Replays}
 	return b.ReplaysDownload(cmd.Context(), BrowsersReplaysDownloadInput{Identifier: args[0], ReplayID: args[1], Output: out})
 }

cmd/deploy.go

@@ -531,19 +531,22 @@ func followDeployment(ctx context.Context, client kernel.Client, deploymentID st
 			if err == nil {
 				fmt.Println(string(bs))
 			}
-			// Check for terminal states
-			if data.Event == "deployment_state" {
-				deploymentState := data.AsDeploymentState()
-				status := deploymentState.Deployment.Status
-				if status == string(kernel.DeploymentGetResponseStatusFailed) ||
-					status == string(kernel.DeploymentGetResponseStatusStopped) ||
-					status == string(kernel.DeploymentGetResponseStatusRunning) {
-					return nil
-				}
+		// Check for terminal states
+		if data.Event == "deployment_state" {
+			deploymentState := data.AsDeploymentState()
+			status := deploymentState.Deployment.Status
+			if status == string(kernel.DeploymentGetResponseStatusFailed) ||
+				status == string(kernel.DeploymentGetResponseStatusStopped) {
+				return fmt.Errorf("deployment %s: %s", status, deploymentState.Deployment.StatusReason)
 			}
-			if data.Event == "error" {
+			if status == string(kernel.DeploymentGetResponseStatusRunning) {
 				return nil
 			}
+		}
+		if data.Event == "error" {
+			errorEv := data.AsErrorEvent()
+			return fmt.Errorf("%s: %s", errorEv.Error.Code, errorEv.Error.Message)
+		}
 			continue
 		}
 

cmd/invoke.go

@@ -180,18 +180,21 @@ func runInvoke(cmd *cobra.Command, args []string) error {
 			if err == nil {
 				fmt.Println(string(bs))
 			}
-			// Check for terminal states
-			if ev.Event == "invocation_state" {
-				stateEv := ev.AsInvocationState()
-				status := stateEv.Invocation.Status
-				if status == string(kernel.InvocationGetResponseStatusSucceeded) ||
-					status == string(kernel.InvocationGetResponseStatusFailed) {
-					return nil
-				}
-			}
-			if ev.Event == "error" {
+		// Check for terminal states
+		if ev.Event == "invocation_state" {
+			stateEv := ev.AsInvocationState()
+			status := stateEv.Invocation.Status
+			if status == string(kernel.InvocationGetResponseStatusSucceeded) {
 				return nil
 			}
+			if status == string(kernel.InvocationGetResponseStatusFailed) {
+				return fmt.Errorf("invocation failed")
+			}
+		}
+		if ev.Event == "error" {
+			errEv := ev.AsError()
+			return fmt.Errorf("%s: %s", errEv.Error.Code, errEv.Error.Message)
+		}
 			continue
 		}