bpftool: fix typo in struct_ops map FD generation for light skeleton#12136
Open
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Open
bpftool: fix typo in struct_ops map FD generation for light skeleton#12136kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 523d2f4 |
Author
|
Upstream branch: 523d2f4 |
7d686fa to
efb15b0
Compare
ceeb3aa to
ec31e3e
Compare
Author
|
Upstream branch: 3db0419 |
efb15b0 to
c960422
Compare
ec31e3e to
b3beebb
Compare
Author
|
Upstream branch: b1fcdf9 |
When generating light skeletons for BPF programs containing struct_ops maps, bpftool incorrectly outputs a stray literal 't' instead of a tab character for the map file descriptor member in the links structure. This causes a compilation error when the generated light skeleton is used. Correct the format string by replacing 't' with '\t'. Fixes: 08ac454 ("libbpf: Auto-attach struct_ops BPF maps in BPF skeleton") Signed-off-by: Siddharth Nayyar <sidnayyar@google.com> Acked-by: Quentin Monnet <qmo@kernel.org>
c960422 to
ce03985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpftool: fix typo in struct_ops map FD generation for light skeleton
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1097896