Skip to content

Commit ba0817c

Browse files
committed
parameter precedence corrected & simplified
1 parent d5cff22 commit ba0817c

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

src/keboola/http_client/http.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from requests.adapters import HTTPAdapter
1010
from urllib3.util import Retry
1111

12+
1213
Cookie = "dict[str, str] | CookieJar"
1314

1415
METHOD_RETRY_WHITELIST = ("GET", "POST", "PATCH", "UPDATE", "PUT", "DELETE")
@@ -164,18 +165,10 @@ def _request_raw(self, method: str, endpoint_path: str | None = None, **kwargs)
164165

165166
s.headers.update(headers)
166167

167-
# Update parameters
168-
params = kwargs.pop("params", {})
169-
if params is None:
170-
params = {}
171-
172-
# Default parameters
173-
if self._default_params is not None:
174-
all_pars = {**params, **self._default_params}
175-
kwargs.update({"params": all_pars})
176-
177-
else:
178-
kwargs.update({"params": params})
168+
# Merge default and custom parameters when applicable
169+
if self._default_params and type(self._default_params) is dict:
170+
params = kwargs.pop("params", {}) or {}
171+
kwargs["params"] = {**self._default_params, **params}
179172

180173
r = self._requests_retry_session(session=s).request(method, url, **kwargs)
181174
return r

0 commit comments

Comments
 (0)