-
Notifications
You must be signed in to change notification settings - Fork 446
feature: Validate loopvar comment #3914
Copy link
Copy link
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Type
Projects
Status
Done
Feature Description
This TODO describes a loopvar issue:
kcp/staging/src/github.com/kcp-dev/cli/pkg/workspace/plugin/create_test.go
Line 254 in 301a8f7
It's very possible that this predates go1.21/1.22 where the looopvar scope was changed.
Proposed Solution
Validate that the test has no loopvar-related issues and remove the comment.
Alternative Solutions
No response
Want to contribute?
Additional Context
No response