Refactor OpBatcher code: constants, formatting, and unused params

Co-authored-by: kbambridge1 <kbambridge1@gmail.com>

Author: cursoragent

internal/controller/opbatcher_controller.go

@@ -42,6 +42,11 @@ import (
 // OpBatcherFinalizer is the finalizer for OpBatcher resources
 const OpBatcherFinalizer = "opbatcher.optimism.io/finalizer"
 
+// Node type constants
+const (
+	NodeTypeSequencer = "sequencer"
+)
+
 // Phase constants for OpBatcher status
 const (
 	OpBatcherPhasePending = "Pending"
@@ -141,7 +146,7 @@ func (r *OpBatcherReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 			goto updateStatus
 		}
 		// Check if sequencer is running and is actually a sequencer
-		if sequencer.Spec.NodeType != "sequencer" {
+		if sequencer.Spec.NodeType != NodeTypeSequencer {
 			utils.SetCondition(&opBatcher.Status.Conditions, "SequencerReference", metav1.ConditionFalse, "InvalidSequencer", "Referenced OpNode is not a sequencer")
 			opBatcher.Status.Phase = OpBatcherPhaseError
 			goto updateStatus
@@ -340,7 +345,7 @@ func (r *OpBatcherReconciler) validatePrivateKeySecret(ctx context.Context, opBa
 }
 
 // testL1Connectivity tests connectivity to L1 RPC endpoint
-func (r *OpBatcherReconciler) testL1Connectivity(ctx context.Context, network *optimismv1alpha1.OptimismNetwork) error {
+func (r *OpBatcherReconciler) testL1Connectivity(_ context.Context, network *optimismv1alpha1.OptimismNetwork) error {
 	// For now, we'll do a basic validation that the URL is set and looks valid
 	// In a full implementation, this would make an actual RPC call
 	if network.Spec.L1RpcUrl == "" {
@@ -355,7 +360,7 @@ func (r *OpBatcherReconciler) testL1Connectivity(ctx context.Context, network *o
 }
 
 // testL2Connectivity tests connectivity to L2 sequencer
-func (r *OpBatcherReconciler) testL2Connectivity(ctx context.Context, opBatcher *optimismv1alpha1.OpBatcher, sequencerServiceName string) error {
+func (r *OpBatcherReconciler) testL2Connectivity(_ context.Context, _ *optimismv1alpha1.OpBatcher, sequencerServiceName string) error {
 	// For now, we'll do a basic validation that the service name is set
 	// In a full implementation, this would make an actual RPC call to the sequencer
 	if sequencerServiceName == "" {

pkg/resources/deployment.go

@@ -15,7 +15,11 @@ import (
 )
 
 // CreateOpBatcherDeployment creates a Deployment for an OpBatcher instance
-func CreateOpBatcherDeployment(opBatcher *optimismv1alpha1.OpBatcher, network *optimismv1alpha1.OptimismNetwork, sequencerServiceName string) *appsv1.Deployment {
+func CreateOpBatcherDeployment(
+	opBatcher *optimismv1alpha1.OpBatcher,
+	network *optimismv1alpha1.OptimismNetwork,
+	sequencerServiceName string,
+) *appsv1.Deployment {
 	labels := map[string]string{
 		"app.kubernetes.io/name":       "opbatcher",
 		"app.kubernetes.io/instance":   opBatcher.Name,
@@ -148,7 +152,11 @@ func CreateOpBatcherDeployment(opBatcher *optimismv1alpha1.OpBatcher, network *o
 }
 
 // buildOpBatcherArgs builds command line arguments for op-batcher
-func buildOpBatcherArgs(opBatcher *optimismv1alpha1.OpBatcher, network *optimismv1alpha1.OptimismNetwork, sequencerServiceName string) []string {
+func buildOpBatcherArgs(
+	opBatcher *optimismv1alpha1.OpBatcher,
+	network *optimismv1alpha1.OptimismNetwork,
+	sequencerServiceName string,
+) []string {
 	args := []string{}
 
 	// L1 RPC configuration from OptimismNetwork
@@ -255,7 +263,10 @@ func buildOpBatcherArgs(opBatcher *optimismv1alpha1.OpBatcher, network *optimism
 }
 
 // buildOpBatcherEnvVars builds environment variables for op-batcher
-func buildOpBatcherEnvVars(opBatcher *optimismv1alpha1.OpBatcher, network *optimismv1alpha1.OptimismNetwork) []corev1.EnvVar {
+func buildOpBatcherEnvVars(
+	_ *optimismv1alpha1.OpBatcher,
+	_ *optimismv1alpha1.OptimismNetwork,
+) []corev1.EnvVar {
 	envVars := []corev1.EnvVar{
 		{
 			Name: "POD_NAME",