Skip to content

Commit 84a4e52

Browse files
committed
edit
1 parent 957ee46 commit 84a4e52

4 files changed

Lines changed: 16 additions & 1 deletion

File tree

commands/critic-d.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,19 @@ Based on context you have of the codebase, task itself and step by step plan; ge
6969

7070
- Make sure generated custom critic is still generic enough but also questions are towards correct and relevant concepts of the feature and the codease, otherwise next phase might miss undocumented details. We want custom critic to be custom tailored to the concepts of the codebase and the feature itself and not to implementation details.
7171

72+
- Make sure generated prompt includes output instructions "Create a `critic.md` file in the same directory as the implementation plan. And this output file has high level summary on top".
73+
74+
- Make sure generated prompt includes:
75+
76+
"""
77+
## Output Format
78+
79+
For each risk found, document:
80+
81+
Desc, Risk Desc, Severity (| Low / Medium / High |), Impact, ELI5 desc, Affected areas, Mitigation** (Medium/High only) and Category (| Breaking change / Import error / Circular import / Package discovery / Stale cache / Missing file / Phase ordering |)
82+
83+
"""
84+
7285
- Save the generated prompt** as `dynamic_critic_prompt.md` in the same directory as the `step_by_step_plan.md`.
7386
- Print the generated prompt** in the conversation so the user can read it.
7487
- Ask the user: *"Here's the dynamic critic prompt I generated. Should I run it now?"*

commands/dead-code-index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ For each candidate, document:
3232
- **Assumed intent** — based on the code's content (naming, structure, fields, parameters), what was this likely meant to do? What direction was it heading? This is inference, not fact — label it as such.
3333
- **Confidence** (Definite / Likely / Uncertain)
3434
- **Search command** — a ready-to-run `grep -rn` command to find all mentions of this code in the codebase
35+
- **Mark for removal in future?** — (leave empty — human marks "yes" to approve future removal)
3536

3637
Do NOT delete anything. This is an inventory only.
3738

src/APPENDIX4_Adding_New_Feature.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Suggest mitigation strategies for Medium/High risks.
8383
Analyze how this feature will interact with the existing codebase:
8484
8585
1. Read all relevant module interfaces and implementations
86-
2. Create devdocs/features/planned/feat_X_[FEATURE_NAME]/critic.md
86+
2. Create critic.md in step by step plan directory
8787
8888
8989

src/APPENDIX5_Useful.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ For each candidate, document:
148148
- **Assumed intent** — based on the code's content (naming, structure, fields, parameters), what was this likely meant to do? What direction was it heading? This is inference, not fact — label it as such.
149149
- **Confidence** (Definite / Likely / Uncertain)
150150
- **Search command** — a ready-to-run `grep -rn` command to find all mentions of this code in the codebase
151+
- **Mark for removal in future?** — (empty — human marks "yes" to approve future removal)
151152
152153
Do NOT delete anything. This is an inventory only.
153154

0 commit comments

Comments
 (0)