From ee1736a1d874a25fbf8a7552c2fefec8c670632c Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 3 Oct 2022 04:24:24 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- src/graph_tool/collection/konect.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/graph_tool/collection/konect.py b/src/graph_tool/collection/konect.py index 75bcc6ac..fb57bbdd 100644 --- a/src/graph_tool/collection/konect.py +++ b/src/graph_tool/collection/konect.py @@ -103,7 +103,26 @@ def get_koblenz_network_data(name): ftemp.seek(0) with TemporaryDirectory(suffix=name) as tempdir: with tarfile.open(fileobj=ftemp, mode='r:bz2') as tar: - tar.extractall(path=tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar, path=tempdir) g = load_koblenz_dir(tempdir) return g From 48c10316d585dd505eb15bda70dd27de3575876d Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 23:26:42 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- src/graph_tool/collection/konect.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graph_tool/collection/konect.py b/src/graph_tool/collection/konect.py index fb57bbdd..23c7167b 100644 --- a/src/graph_tool/collection/konect.py +++ b/src/graph_tool/collection/konect.py @@ -119,7 +119,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tar, path=tempdir)