diff --git a/src/graph_tool/collection/konect.py b/src/graph_tool/collection/konect.py index 75bcc6ac..23c7167b 100644 --- a/src/graph_tool/collection/konect.py +++ b/src/graph_tool/collection/konect.py @@ -103,7 +103,26 @@ def get_koblenz_network_data(name): ftemp.seek(0) with TemporaryDirectory(suffix=name) as tempdir: with tarfile.open(fileobj=ftemp, mode='r:bz2') as tar: - tar.extractall(path=tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=tempdir) g = load_koblenz_dir(tempdir) return g