Listen on unix sockets #618
Open
+189
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dometto
force-pushed
the
listen_unix_socket
branch
2 times, most recently
from
f041fc7 to
18e056b
Compare
dometto
force-pushed
the
listen_unix_socket
branch
from
1c93488 to
b2e4405
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
Not seeing these test failures locally -- advice very welcome! |
dometto
commented
Dec 2, 2025
| }); | ||
|
|
||
| it("unix socket HTTP request", function (done) { | ||
| http |
Contributor
Author
There was a problem hiding this comment.
Using http.request because I couldn't get the fetch API to work with a unix socket.
minrk
reviewed
Dec 5, 2025
|
|
||
| if (args.socket) { | ||
| listen.proxyTarget = [args.socket]; | ||
| logger.warn( |
Member
There was a problem hiding this comment.
Probably best to warn only if conflicting args are specified. It's a bit confusing to get a warning when everything is behaving as intended.
I think commander can help with this by adding .conflicts() to express these conflicts: https://github.com/tj/commander.js?tab=readme-ov-file#more-configuration
|
|
||
| if (args.apiSocket) { | ||
| listen.apiSocket = [args.apiSocket]; | ||
| logger.warn( |
|
|
||
| if (args.metricsSocket) { | ||
| listen.metricsSocket = [args.metricsSocket]; | ||
| logger.warn( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where #592 introduced the ability to proxy to servers running on a unix domain socket, this PR allows the proxy itself to listen on a unix socket.
--socket,--api-socket, and--metrics-socketto provide socket path for the proxy, api, and metrics servers.setupProxytest helper method to allow passing in a unix socket instead of a TCP port for test servers to listen on.Using the changes in this PR, we can securely run JupyterHub on a shared server with multiple users, using a proxy auth strategy.