Skip to content

tests/test_client.py::test_run_all_notebooks[update-display-id.ipynb-opts14] fails for ipython 9.8 #336

@drorspei

Description

@drorspei

Hey there!

The test tests/test_client.py::test_run_all_notebooks[update-display-id.ipynb-opts14] fails with IPython 9.8.

IPython 9.8 changed the handling of execution_count in InteractiveShell, so that it is incremented before user code is run. The aforementioned test accesses the shell's execution_count and expects it to be the value of the current cell being run, instead of the new value.

I've put a fix PR #335

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions