From b9cd9a1754e7761dcb5c931f837c355623d273ae Mon Sep 17 00:00:00 2001 From: s0c0yrg Date: Thu, 28 May 2026 19:18:14 +0530 Subject: [PATCH 1/2] issues 938-document inheritance support Signed-off-by: Swati Chauhan --- .../java/org/junit/jupiter/api/AssertionFailureBuilder.java | 2 ++ .../jupiter/params/aggregator/ArgumentAccessException.java | 2 ++ .../params/aggregator/ArgumentsAggregationException.java | 2 ++ .../params/provider/AnnotationBasedArgumentsProvider.java | 2 ++ 4 files changed, 8 insertions(+) diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java index d0416c36a167..0bd88008c596 100644 --- a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java +++ b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java @@ -30,6 +30,8 @@ *

Using this builder ensures consistency in how failure message are formatted * within JUnit Jupiter and for custom user-defined assertions. * + *

This class is not intended to be extended by clients. + * * @since 5.9 * @see AssertionFailedError */ diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java index 6fecc8c9fc5a..df60a42a0042 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java @@ -22,6 +22,8 @@ * {@link ArgumentsAccessor} if an error occurs while accessing * or converting an argument. * + *

This class is not intended to be extended by clients. + * * @since 5.2 * @see ArgumentsAccessor */ diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java index be7b9019a8d5..0d55377fd6ba 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java @@ -22,6 +22,8 @@ * {@link ArgumentsAggregator} when an error occurs while aggregating * arguments. * + *

This class is not intended to be extended by clients. + * * @since 5.2 * @see ArgumentsAggregator */ diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java index 755dd5d52e40..bf7515f1f041 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java @@ -30,6 +30,8 @@ * {@link ArgumentsProvider} implementations that also need to consume an * annotation in order to provide the arguments. * + *

This class is designed for extension. + * * @since 5.10 * @see org.junit.jupiter.params.ParameterizedClass * @see org.junit.jupiter.params.ParameterizedTest From a237ce7d9e5f47260e508e3e91a4f3f2dc9740ab Mon Sep 17 00:00:00 2001 From: Swati Chauhan Date: Sat, 30 May 2026 10:42:29 +0530 Subject: [PATCH 2/2] issues 938-addressing-review-comments Signed-off-by: Swati Chauhan --- .../java/org/junit/jupiter/api/AssertionFailureBuilder.java | 5 ++++- .../jupiter/params/aggregator/ArgumentAccessException.java | 4 +++- .../params/aggregator/ArgumentsAggregationException.java | 4 +++- .../params/provider/AnnotationBasedArgumentsProvider.java | 2 ++ 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java index 0bd88008c596..562cf2857441 100644 --- a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java +++ b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertionFailureBuilder.java @@ -30,7 +30,10 @@ *

Using this builder ensures consistency in how failure message are formatted * within JUnit Jupiter and for custom user-defined assertions. * - *

This class is not intended to be extended by clients. + *

Extensibility

+ * + *

Although it is technically possible to extend this class, extension is + * strongly discouraged. * * @since 5.9 * @see AssertionFailedError diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java index df60a42a0042..eb8e296308de 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentAccessException.java @@ -22,7 +22,9 @@ * {@link ArgumentsAccessor} if an error occurs while accessing * or converting an argument. * - *

This class is not intended to be extended by clients. + *

Extensibility

+ * + *

This class is designed for extension. * * @since 5.2 * @see ArgumentsAccessor diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java index 0d55377fd6ba..3b906b409352 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAggregationException.java @@ -22,7 +22,9 @@ * {@link ArgumentsAggregator} when an error occurs while aggregating * arguments. * - *

This class is not intended to be extended by clients. + *

Extensibility

+ * + *

This class is designed for extension. * * @since 5.2 * @see ArgumentsAggregator diff --git a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java index bf7515f1f041..1c866e401c78 100644 --- a/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java +++ b/junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/AnnotationBasedArgumentsProvider.java @@ -30,6 +30,8 @@ * {@link ArgumentsProvider} implementations that also need to consume an * annotation in order to provide the arguments. * + *

Extensibility

+ * *

This class is designed for extension. * * @since 5.10