driver-ssh: use lazy % formatting with logging

Change logging formatting to use %-formatting
so that formatting is deferred until the log
is printed [1].

[1]
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html

Signed-off-by: Albert Esteve <aesteve@redhat.com>

Author: aesteve-rh

packages/jumpstarter-driver-ssh/jumpstarter_driver_ssh/client.py

@@ -93,10 +93,10 @@ def run(self, options: SSHCommandRunOptions, args) -> SSHCommandRunResult:
                 port = parsed.port
                 if not host or not port:
                     raise ValueError(f"Invalid address format: {address}")
-                self.logger.debug(f"Using direct TCP connection for SSH - host: {host}, port: {port}")
+                self.logger.debug("Using direct TCP connection for SSH - host: %s, port: %s", host, port)
                 return self._run_ssh_local(host, port, ssh_command, options, default_username, ssh_identity, args)
             except (DriverMethodNotImplemented, ValueError) as e:
-                self.logger.error(f"Direct address connection failed ({e}), falling back to SSH port forwarding")
+                self.logger.error("Direct address connection failed (%s), falling back to SSH port forwarding", e)
                 return self.run(SSHCommandRunOptions(
                     direct=False,
                     capture_output=options.capture_output,
@@ -109,7 +109,7 @@ def run(self, options: SSHCommandRunOptions, args) -> SSHCommandRunResult:
                 client=self.tcp,
             ) as addr:
                 host, port = addr
-                self.logger.debug(f"SSH port forward established - host: {host}, port: {port}")
+                self.logger.debug("SSH port forward established - host: %s, port: %s", host, port)
                 return self._run_ssh_local(host, port, ssh_command, options, default_username, ssh_identity, args)
 
     def _run_ssh_local(self, host, port, ssh_command, options, default_username, ssh_identity, args):
@@ -125,9 +125,9 @@ def _run_ssh_local(self, host, port, ssh_command, options, default_username, ssh
                 # Set proper permissions (600) for SSH key
                 os.chmod(temp_file.name, 0o600)
                 identity_file = temp_file.name
-                self.logger.debug(f"Created temporary identity file: {identity_file}")
+                self.logger.debug("Created temporary identity file: %s", identity_file)
             except Exception as e:
-                self.logger.error(f"Failed to create temporary identity file: {e}")
+                self.logger.error("Failed to create temporary identity file: %s", e)
                 if temp_file:
                     try:
                         os.unlink(temp_file.name)
@@ -152,9 +152,9 @@ def _run_ssh_local(self, host, port, ssh_command, options, default_username, ssh
             if identity_file:
                 try:
                     os.unlink(identity_file)
-                    self.logger.debug(f"Cleaned up temporary identity file: {identity_file}")
+                    self.logger.debug("Cleaned up temporary identity file: %s", identity_file)
                 except Exception as e:
-                    self.logger.warning(f"Failed to clean up temporary identity file {identity_file}: {e}")
+                    self.logger.warning("Failed to clean up temporary identity file %s: %s", identity_file, str(e))
 
     def _build_ssh_command_args(self, ssh_command, port, default_username, identity_file, args):
         """Build initial SSH command arguments"""
@@ -226,8 +226,8 @@ def _separate_ssh_options_and_command_args(self, args):
             i += 1
 
         # Debug output
-        self.logger.debug(f"SSH options: {ssh_options}")
-        self.logger.debug(f"Command args: {command_args}")
+        self.logger.debug("SSH options: %s", ssh_options)
+        self.logger.debug("Command args: %s", command_args)
         return ssh_options, command_args
 
 
@@ -243,7 +243,7 @@ def _build_final_ssh_command(self, ssh_args, ssh_options, host, command_args):
         # Add command arguments
         ssh_args.extend(command_args)
 
-        self.logger.debug(f"Running SSH command: {ssh_args}")
+        self.logger.debug("Running SSH command: %s", ssh_args)
         return ssh_args
 
     def _execute_ssh_command(self, ssh_args, options: SSHCommandRunOptions) -> SSHCommandRunResult:
@@ -253,7 +253,8 @@ def _execute_ssh_command(self, ssh_args, options: SSHCommandRunOptions) -> SSHCo
             return SSHCommandRunResult.from_completed_process(result)
         except FileNotFoundError:
             self.logger.error(
-                f"SSH command '{ssh_args[0]}' not found. Please ensure SSH is installed and available in PATH."
+                "SSH command '%s' not found. Please ensure SSH is installed and available in PATH.",
+                ssh_args[0],
             )
             return SSHCommandRunResult(
                 return_code=127,  # Standard exit code for "command not found"

packages/jumpstarter-driver-ssh/jumpstarter_driver_ssh/driver_test.py

@@ -684,10 +684,11 @@ def test_ssh_identity_temp_file_cleanup_error():
                             mock_chmod.assert_called_once_with("/tmp/test_ssh_key_12345", 0o600)
 
                             # Verify warning was logged
-                            mock_logger.warning.assert_called_once()
-                            warning_call = mock_logger.warning.call_args[0][0]
-                            assert "Failed to clean up temporary identity file" in warning_call
-                            assert "/tmp/test_ssh_key_12345" in warning_call
+                            mock_logger.warning.assert_called_once_with(
+                                "Failed to clean up temporary identity file %s: %s",
+                                "/tmp/test_ssh_key_12345",
+                                str(mock_unlink.side_effect)
+                            )
 
                             assert result.return_code == 0
                             assert result.stdout == "some stdout"