Merge pull request #142 from julwrites/staging

Escaping markdown better

Author: julwrites

pkg/app/passage.go

@@ -43,13 +43,15 @@ func escapeMarkdownV2(s string) string {
 	// Note: '^' is not in this list. Let's assume it doesn't need escaping.
 	// The logic should be to escape these characters *only* when they are not part of a formatting tag.
 	// However, since we are processing raw text nodes, any special character should be escaped.
-	r := strings.NewReplacer(
-		"_", `\_`, "*", `\*`, "[", `\[`, "]", `\]`, "(", `\(`, ")", `\)`,
-		"~", `\~`, "`", "\\`", ">", `\>`, "#", `\#`, "+", `\+`, "-", `\-`,
-		"=", `\=`, "|", `\|`, "{", `\{`, "}", `\}`, ".", `\.`, "!", `\!`,
-		`\`, `\\`,
-	)
-	return r.Replace(s)
+	var sb strings.Builder
+	for _, r := range s {
+		switch r {
+		case '_', '*', '[', ']', '(', ')', '~', '`', '>', '#', '+', '-', '=', '|', '{', '}', '.', '!', '\\':
+			sb.WriteRune('\\')
+		}
+		sb.WriteRune(r)
+	}
+	return sb.String()
 }
 
 // Helper functions for parsing

pkg/app/passage_test.go

@@ -139,6 +139,14 @@ func TestParsePassageFromHtml(t *testing.T) {
 			t.Errorf("ParsePassageFromHtml() = %v, want %v", got, expected)
 		}
 	})
+
+	t.Run("Dot escaping", func(t *testing.T) {
+		html := `heaven.`
+		expected := `heaven\.`
+		if got := ParsePassageFromHtml(html); got != expected {
+			t.Errorf("ParsePassageFromHtml() = %v, want %v", got, expected)
+		}
+	})
 }
 
 func TestCheckBibleReference(t *testing.T) {