Wildcards in routes?

[sebastienratez]

Hi there!

I am trying to implement a wildcard in the routes, such as showing in https://auth0.com/docs/quickstart/backend/php (see $router->before('GET', '/secured/.*', function() {...)

Do you think there would be something similar in one-php? Basically what that code is doing is adding a controller before any other to make sure any route in this path requires authentication.

Thanks

[juliomatcom]

Hello!
Cool, would be nice, any pull request is welcome 🤗

[sebastienratez]

That's a good idea. I have a long week-end coming up so I might have time to at least evaluate the work to be done Cheers to that, S.

…

On 10 April 2017 at 21:53, Julio Cesar Martin ***@***.***> wrote: Hello! Cool, would be nice, any pull request is welcome 🤗 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGkQ3ShgMWGMXmEKtWhNgpr0wkfXAVB8ks5ruoizgaJpZM4MnEgJ> .

[sebastienratez]

In fact it looks very easy. Question: why do you decided to exit traverseRoutes after the first matching route is found and executed? Would there be a problem to execute all the matching routes?
Other than this, I suppose the idea is to update matchUriWithRoute and CompareSegments. That shouldn't take too long, I'll see if I can do it on thursday or friday

[juliomatcom]

Would there be a problem to execute all the matching routes?

No, as long as we return the proper boolean at the end of the loop.

Maybe we can add the before as an special method and execute it always first 🤔 .. thinking we need to modify the processUri regex to match * routes too.

[sebastienratez]

before would be a good idea, but logically it would mean that for any matching route, that before callback would get executed. The wildcard's purpose is complementary: for example you could have a call to `->before("/context/.*", callback);` as well. Maybe as a second feature request?

…

On 11 April 2017 at 12:35, Julio Cesar Martin ***@***.***> wrote: Would there be a problem to execute all the matching routes? Not, as long we return true at the end of the loop. Maybe we can add the before as an special method and execute it always first, and I'm thinking we need to modify the processUri regex to match * routes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGkQ3b3_NRQDP4ANmpjnkE-xCp83Ia9wks5ru1dwgaJpZM4MnEgJ> .