C SDK: Document thread safety and fix js_cleanup#33
Closed
clemensv wants to merge 1 commit into
Closed
Conversation
- Add Thread Safety section to README documenting safe usage patterns - Fix js_cleanup() to call js_regex_cache_clear() before resetting allocator - Document what is and isn't thread-safe Fixes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents thread safety requirements for the C SDK and fixes js_cleanup() to properly clear the regex cache.
Changes
README.md: Add comprehensive Thread Safety section documenting:
json_source_locator.c: Fix js_cleanup() to call js_regex_cache_clear() before resetting the allocator
Testing
Fixes #23