fix(installer): remove nsJSON intermediate error checks causing false positives

Root cause: nsJSON operations set the NSIS error flag even when succeeding.
The CI tests explicitly note "Don't check intermediate errors" and this fix
aligns the installer with the proven CI test pattern.

Changes:
- Remove ClearErrors + ${If} ${Errors} checks after each nsJSON::Set call
- Use backticks for key names (matching CI syntax)
- Use lowercase /value without /END (matching CI syntax)
- Only validate final nsJSON::Serialize result

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: Test

scripts/installer/mcpb-installer.nsi

@@ -415,50 +415,25 @@ Function CreateMCPBConfig
     DetailPrint "Created directory: $PROFILE\.mcpb"
 
     ; Construct config.json using nsJSON
-    ; CRITICAL: nsJSON requires backticks for literal JSON values, not double quotes
-    ClearErrors
+    ; CRITICAL: Match CI test pattern - don't check intermediate errors, just verify final result
+    ; nsJSON operations may set error flag even when succeeding (false positives)
     nsJSON::Set /value `{}`
-    ${If} ${Errors}
-        StrCpy $ErrorMessage "Failed to initialize config JSON"
-        DetailPrint "$ErrorMessage"
-        SetErrors
-        Return
-    ${EndIf}
-
-    ; Set server_url
-    ClearErrors
-    nsJSON::Set "server_url" /VALUE `"$ServerUrl"` /END
-    ${If} ${Errors}
-        StrCpy $ErrorMessage "Failed to set server_url in config"
-        DetailPrint "$ErrorMessage"
-        SetErrors
-        Return
-    ${EndIf}
+    nsJSON::Set `server_url` /value `"$ServerUrl"`
+    nsJSON::Set `access_token` /value `"$AccessToken"`
+    nsJSON::Set `refresh_token` /value `"$RefreshToken"`
 
-    ; Set access_token
-    ClearErrors
-    nsJSON::Set "access_token" /VALUE `"$AccessToken"` /END
-    ${If} ${Errors}
-        StrCpy $ErrorMessage "Failed to set access_token in config"
-        DetailPrint "$ErrorMessage"
-        SetErrors
-        Return
-    ${EndIf}
+    ; Serialize to JSON string - this is where we verify success
+    nsJSON::Serialize /PRETTY /UNICODE
+    Pop $0  ; JSON string
 
-    ; Set refresh_token
-    ClearErrors
-    nsJSON::Set "refresh_token" /VALUE `"$RefreshToken"` /END
-    ${If} ${Errors}
-        StrCpy $ErrorMessage "Failed to set refresh_token in config"
+    ; Verify we got valid JSON (not empty)
+    ${If} $0 == ""
+        StrCpy $ErrorMessage "Failed to create config JSON"
         DetailPrint "$ErrorMessage"
         SetErrors
         Return
     ${EndIf}
 
-    ; Serialize to JSON string
-    nsJSON::Serialize /PRETTY /UNICODE
-    Pop $0  ; JSON string
-
     DetailPrint "Config JSON: $0"
 
     ; Write config.json file

src/code_indexer/__init__.py

@@ -6,5 +6,5 @@
 HNSW graph indexing (O(log N) complexity).
 """
 
-__version__ = "8.4.37"
+__version__ = "8.4.38"
 __author__ = "Seba Battig"