Integration test for multiple calls to set the same cookie

Author: FagnerMartinsBrack

pom.xml

@@ -189,6 +189,18 @@
       <version>2.0.2-beta</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
+      <artifactId>httpclient</artifactId>
+      <version>4.3.3</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
+      <artifactId>fluent-hc</artifactId>
+      <version>4.3.3</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
   <profiles>
     <profile>

src/main/java/org/jscookie/Cookies.java

@@ -145,7 +145,7 @@ public synchronized void set( String name, String value, AttributesDefinition at
 			return;
 		}
 
-		response.addHeader( "Set-Cookie", header.toString() );
+		setCookie( header.toString(), response );
 	}
 
 	@Override
@@ -247,6 +247,13 @@ private Attributes extend( AttributesDefinition... mergeables ) {
 		return result;
 	}
 
+	private void setCookie( String cookieValue, HttpServletResponse response ) {
+		if ( response.getHeaders( "Set-Cookie" ).contains( cookieValue ) ) {
+			return;
+		}
+		response.addHeader( "Set-Cookie", cookieValue );
+	}
+
 	private String encode( String decoded ) {
 		return encode( decoded, new HashSet<Integer>() );
 	}

src/test/java/org/jscookie/test/integration/encoding/CookiesEncodingIT.java

@@ -1,6 +1,5 @@
 package org.jscookie.test.integration.encoding;
 
-import java.io.File;
 import java.net.URL;
 import java.util.concurrent.TimeUnit;
 
@@ -14,10 +13,10 @@
 import org.jboss.shrinkwrap.api.ShrinkWrap;
 import org.jboss.shrinkwrap.api.importer.ExplodedImporter;
 import org.jboss.shrinkwrap.api.spec.WebArchive;
-import org.jboss.shrinkwrap.resolver.api.maven.Maven;
 import org.jscookie.test.integration.qunit.QUnitPageObject;
 import org.jscookie.test.integration.qunit.QUnitResults;
 import org.jscookie.test.integration.test.utils.Debug;
+import org.jscookie.test.unit.utils.IntegrationUtils;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -31,26 +30,12 @@ public class CookiesEncodingIT {
 
 	@Deployment
 	public static Archive<?> createDeployment() {
-		boolean RECURSIVE_TRUE = true;
-
 		GenericArchive qunitFiles = ShrinkWrap.create( GenericArchive.class )
 			.as( ExplodedImporter.class )
 			.importDirectory( "bower_components/js-cookie/" )
 			.as( GenericArchive.class );
 
-		WebArchive war = ShrinkWrap.create( WebArchive.class )
-			.addPackage( "org.jscookie" )
-			.addPackages( RECURSIVE_TRUE, "org.jscookie.test.integration" )
-			.addAsLibraries(
-				Maven.resolver()
-					.loadPomFromFile( "pom.xml" )
-					.resolve(
-						"joda-time:joda-time",
-						"com.fasterxml.jackson.core:jackson-databind"
-					)
-					.withTransitivity()
-					.as( File.class )
-			)
+		WebArchive war = IntegrationUtils.createCommonDeployment()
 			.merge( qunitFiles, "/", Filters.includeAll() );
 
 		System.out.println( " ----- LOGGING THE FILES ADDED TO JBOSS" );

src/test/java/org/jscookie/test/integration/write/MultipleSetCookieServlet.java

@@ -0,0 +1,19 @@
+package org.jscookie.test.integration.write;
+
+import javax.servlet.annotation.WebServlet;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.jscookie.Cookies;
+
+@WebServlet( "/multiple-set-cookie" )
+public class MultipleSetCookieServlet extends HttpServlet {
+	private static final long serialVersionUID = 1;
+	@Override
+	public void doGet( HttpServletRequest request, HttpServletResponse response ) {
+		Cookies cookies = Cookies.initFromServlet( request, response );
+		cookies.set( "c", "v" );
+		cookies.set( "c", "v" );
+	}
+}

src/test/java/org/jscookie/test/integration/write/SetCookieIT.java

@@ -0,0 +1,49 @@
+package org.jscookie.test.integration.write;
+
+import java.io.IOException;
+import java.net.URL;
+
+import org.apache.http.Header;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.fluent.Request;
+import org.apache.http.client.fluent.Response;
+import org.jboss.arquillian.container.test.api.Deployment;
+import org.jboss.arquillian.container.test.api.RunAsClient;
+import org.jboss.arquillian.junit.Arquillian;
+import org.jboss.arquillian.test.api.ArquillianResource;
+import org.jboss.shrinkwrap.api.Archive;
+import org.jboss.shrinkwrap.api.spec.WebArchive;
+import org.jscookie.test.unit.utils.IntegrationUtils;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+@RunWith( Arquillian.class )
+public class SetCookieIT {
+	@Deployment
+	public static Archive<?> createDeployment() {
+		WebArchive war = IntegrationUtils.createCommonDeployment();
+
+		System.out.println( " ----- LOGGING THE FILES ADDED TO JBOSS" );
+		System.out.println( war.toString( true ) );
+		System.out.println( " ----- END OF LOGGING THE FILES ADDED TO JBOSS" );
+
+		return war;
+	}
+
+	@RunAsClient
+	@Test
+	public void read_qunit_test( @ArquillianResource URL baseURL ) throws IOException {
+		HttpResponse content = request( baseURL + "multiple-set-cookie" );
+		Header[] headers = content.getHeaders( "Set-Cookie" );
+		Assert.assertEquals( "Should set a single header", 1, headers.length );
+		Assert.assertEquals( "Should not repeat the value", "c=v; Path=/", headers[ 0 ].getValue() );
+	}
+
+	private HttpResponse request( String url ) throws IOException {
+		Request request = Request.Get( url );
+		Response response = request.execute();
+		HttpResponse httpResponse = response.returnResponse();
+		return httpResponse;
+	}
+}

src/test/java/org/jscookie/test/unit/utils/IntegrationUtils.java

@@ -0,0 +1,26 @@
+package org.jscookie.test.unit.utils;
+
+import java.io.File;
+
+import org.jboss.shrinkwrap.api.ShrinkWrap;
+import org.jboss.shrinkwrap.api.spec.WebArchive;
+import org.jboss.shrinkwrap.resolver.api.maven.Maven;
+
+public class IntegrationUtils {
+	public static WebArchive createCommonDeployment() {
+		boolean RECURSIVE_TRUE = true;
+		return ShrinkWrap.create( WebArchive.class )
+			.addPackage( "org.jscookie" )
+			.addPackages( RECURSIVE_TRUE, "org.jscookie.test.integration" )
+			.addAsLibraries(
+				Maven.resolver()
+					.loadPomFromFile( "pom.xml" )
+					.resolve(
+						"joda-time:joda-time",
+						"com.fasterxml.jackson.core:jackson-databind"
+					)
+					.withTransitivity()
+					.as( File.class )
+			);
+	}
+}