Merge pull request #483 from getloaded/custom-setter-for-aliased-attribute

Allow custom setter methods to run for aliased attributes (fixes #350)

Author: koenpunt

lib/Model.php

@@ -428,7 +428,7 @@ public function __set($name, $value)
 		if (array_key_exists($name, static::$alias_attribute))
 			$name = static::$alias_attribute[$name];
 
-		elseif (method_exists($this,"set_$name"))
+		if (method_exists($this,"set_$name"))
 		{
 			$name = "set_$name";
 			return $this->$name($value);

test/ActiveRecordTest.php

@@ -281,6 +281,22 @@ public function test_alias_attribute_setter()
 		$this->assert_equals($venue->marquee, $venue->name);
 	}
 
+	public function test_alias_attribute_custom_setter()
+	{
+		Venue::$use_custom_set_city_setter = true;
+		$venue = Venue::find(1);
+
+		$venue->mycity = 'cityname';
+		$this->assert_equals($venue->mycity, 'cityname#');
+		$this->assert_equals($venue->mycity, $venue->city);
+
+		$venue->city = 'anothercity';
+		$this->assert_equals($venue->city, 'anothercity#');
+		$this->assert_equals($venue->city, $venue->mycity);
+
+		Venue::$use_custom_set_city_setter = false;
+	}
+
 	public function test_alias_from_mass_attributes()
 	{
 		$venue = new Venue(array('marquee' => 'meme', 'id' => 123));

test/models/Venue.php

@@ -4,6 +4,7 @@ class Venue extends ActiveRecord\Model
 	static $use_custom_get_state_getter = false;
 	static $use_custom_set_state_setter = false;
 
+	static $use_custom_set_city_setter = false;
 
 	static $has_many = array(
 		'events',
@@ -32,5 +33,13 @@ public function set_state($value)
 		else
 			return $this->assign_attribute('state', $value);
 	}
+
+	public function set_city($value)
+	{
+		if (self::$use_custom_set_city_setter)
+			return $this->assign_attribute('city', $value . '#');
+		else
+			return $this->assign_attribute('city', $value);
+	}
 
 }